Changes in uspace/srv/net/netif/lo/lo.c [fe8dfa6:774e6d1a] in mainline

File:

• uspace/srv/net/netif/lo/lo.c (modified) (9 diffs)

uspace/srv/net/netif/lo/lo.c

@@ -48 +48 @@
 #include <packet_client.h>
 #include <net/device.h>
+#include <nil_interface.h>
 #include <netif_skel.h>
-#include <nil_remote.h>
+
+/** Default hardware address. */
+#define DEFAULT_ADDR  0
 
 /** Default address length. */
@@ -57 +60 @@
 #define NAME  "lo"
 
-static uint8_t default_addr[DEFAULT_ADDR_LEN] =
-    {0, 0, 0, 0, 0, 0};
+/** Network interface global data. */
+netif_globals_t netif_globals;
 
 int netif_specific_message(ipc_callid_t callid, ipc_call_t *call,
@@ -71 +74 @@
                 return EBADMEM;
         
-        address->value = default_addr;
+        uint8_t *addr = (uint8_t *) malloc(DEFAULT_ADDR_LEN);
+        memset(addr, DEFAULT_ADDR, DEFAULT_ADDR_LEN);
+        
+        address->value = addr;
         address->length = DEFAULT_ADDR_LEN;
         
@@ -79 +85 @@
 int netif_get_device_stats(device_id_t device_id, device_stats_t *stats)
 {
+        netif_device_t *device;
+        int rc;
+
         if (!stats)
                 return EBADMEM;
-        
-        netif_device_t *device;
-        int rc = find_device(device_id, &device);
+
+        rc = find_device(device_id, &device);
         if (rc != EOK)
                 return rc;
-        
+
         memcpy(stats, (device_stats_t *) device->specific,
             sizeof(device_stats_t));
-        
-        return EOK;
-}
-
-/** Change the loopback state.
- *
- * @param[in] device The device structure.
- * @param[in] state  The new device state.
- *
- * @return New state if changed.
- * @return EOK otherwise.
- *
- */
-static void change_state_message(netif_device_t *device, device_state_t state)
+
+        return EOK;
+}
+
+/** Changes the loopback state.
+ *
+ * @param[in] device    The device structure.
+ * @param[in] state     The new device state.
+ * @return              The new state if changed.
+ * @return              EOK otherwise.
+ */
+static int change_state_message(netif_device_t *device, device_state_t state)
 {
         if (device->state != state) {
                 device->state = state;
                 
-                const char *desc;
-                switch (state) {
-                case NETIF_ACTIVE:
-                        desc = "active";
-                        break;
-                case NETIF_STOPPED:
-                        desc = "stopped";
-                        break;
-                default:
-                        desc = "unknown";
-                }
+                printf("%s: State changed to %s\n", NAME,
+                    (state == NETIF_ACTIVE) ? "active" : "stopped");
                 
-                printf("%s: State changed to %s\n", NAME, desc);
-        }
-}
-
-/** Create and return the loopback network interface structure.
- *
- * @param[in]  device_id New devce identifier.
- * @param[out] device    Device structure.
- *
- * @return EOK on success.
- * @return EXDEV if one loopback network interface already exists.
- * @return ENOMEM if there is not enough memory left.
- *
- */
-static int lo_create(device_id_t device_id, netif_device_t **device)
-{
+                return state;
+        }
+        
+        return EOK;
+}
+
+/** Creates and returns the loopback network interface structure.
+ *
+ * @param[in] device_id The new devce identifier.
+ * @param[out] device   The device structure.
+ * @return              EOK on success.
+ * @return              EXDEV if one loopback network interface already exists.
+ * @return              ENOMEM if there is not enough memory left.
+ */
+static int create(device_id_t device_id, netif_device_t **device)
+{
+        int index;
+
         if (netif_device_map_count(&netif_globals.device_map) > 0)
                 return EXDEV;
-        
+
         *device = (netif_device_t *) malloc(sizeof(netif_device_t));
         if (!*device)
                 return ENOMEM;
-        
+
         (*device)->specific = (device_stats_t *) malloc(sizeof(device_stats_t));
         if (!(*device)->specific) {
@@ -147 +146 @@
                 return ENOMEM;
         }
-        
+
         null_device_stats((device_stats_t *) (*device)->specific);
         (*device)->device_id = device_id;
         (*device)->nil_phone = -1;
         (*device)->state = NETIF_STOPPED;
-        int index = netif_device_map_add(&netif_globals.device_map,
+        index = netif_device_map_add(&netif_globals.device_map,
             (*device)->device_id, *device);
-        
+
         if (index < 0) {
                 free(*device);
@@ -168 +167 @@
 {
         sysarg_t phonehash;
+
         return ipc_connect_to_me(PHONE_NS, SERVICE_LO, 0, 0, &phonehash);
 }
@@ -173 +173 @@
 int netif_probe_message(device_id_t device_id, int irq, void *io)
 {
+        netif_device_t *device;
+        int rc;
+
         /* Create a new device */
-        netif_device_t *device;
-        int rc = lo_create(device_id, &device);
+        rc = create(device_id, &device);
         if (rc != EOK)
                 return rc;
-        
+
+        /* Print the settings */
         printf("%s: Device created (id: %d)\n", NAME, device->device_id);
+
         return EOK;
 }
@@ -186 +190 @@
 {
         netif_device_t *device;
-        int rc = find_device(device_id, &device);
+        size_t length;
+        packet_t *next;
+        int phone;
+        int rc;
+
+        rc = find_device(device_id, &device);
         if (rc != EOK)
                 return EOK;
-        
+
         if (device->state != NETIF_ACTIVE) {
                 netif_pq_release(packet_get_id(packet));
                 return EFORWARD;
         }
-        
-        packet_t *next = packet;
+
+        next = packet;
         do {
                 ((device_stats_t *) device->specific)->send_packets++;
                 ((device_stats_t *) device->specific)->receive_packets++;
-                size_t length = packet_get_data_length(next);
+                length = packet_get_data_length(next);
                 ((device_stats_t *) device->specific)->send_bytes += length;
                 ((device_stats_t *) device->specific)->receive_bytes += length;
                 next = pq_next(next);
-        } while (next);
-        
-        int phone = device->nil_phone;
+        } while(next);
+
+        phone = device->nil_phone;
         fibril_rwlock_write_unlock(&netif_globals.lock);
-        
         nil_received_msg(phone, device_id, packet, sender);
-        
         fibril_rwlock_write_lock(&netif_globals.lock);
+        
         return EOK;
 }
@@ -216 +224 @@
 int netif_start_message(netif_device_t *device)
 {
-        change_state_message(device, NETIF_ACTIVE);
-        return device->state;
+        return change_state_message(device, NETIF_ACTIVE);
 }
 
 int netif_stop_message(netif_device_t *device)
 {
-        change_state_message(device, NETIF_STOPPED);
-        return device->state;
+        return change_state_message(device, NETIF_STOPPED);
 }