Changeset 74359c6 in mainline for uspace/libc/arch

Timestamp:

2006-12-30T13:36:13Z (19 years ago)

Author:

Jakub Jermar <jakub@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

33c0c649

Parents:

66eb2c8

Message:

Improve comments and fix formatting in (sparc64) TLS implementation.
Improve some comments and formatting in sparc64 uspace thread library
code.

Update required msim version.

Location:

uspace/libc/arch/sparc64

Files:

• include/thread.h (modified) (1 diff)
• src/psthread.S (modified) (1 diff)
• src/thread.c (modified) (2 diffs)

uspace/libc/arch/sparc64/include/thread.h

@@ -34 +34 @@
  * @file
  * @brief       sparc64 TLS functions.
- *
- * The implementation is based on the IA-32 implementation which was also
- * designed by Sun and is virtually the same, except the TCB is stored in
- * %g7 (of the normal set).
  */
 

uspace/libc/arch/sparc64/src/psthread.S

@@ -29 +29 @@
 #include <libarch/context_offset.h>
 
-/**
- * Both context_save_arch() and context_restore_arch() are
- * leaf-optimized procedures. This kind of optimization
- * is very important and prevents any implicit window
- * spill/fill/clean traps in these very core kernel
- * functions.
- */
-        
 .text   
 

uspace/libc/arch/sparc64/src/thread.c

@@ -38 +38 @@
 #include <malloc.h>
 
-/** Allocate TLS & TCB for initial module threads
+/*
+ * sparc64 uses thread-local storage data structures, variant II, as described
+ * in:
+ *      Drepper U.: ELF Handling For Thread-Local Storage, 2005
+ */
+
+/** Allocate TLS variant II data structures for a thread.
  *
- * @param data Start of data section
- * @return pointer to tcb_t structure
+ * Only static model is supported.
+ *
+ * @param data Pointer to pointer to thread local data. This is actually an
+ *      output argument.
+ * @param size Size of thread local data.
+ * @return Pointer to TCB structure.
  */
 tcb_t * __alloc_tls(void **data, size_t size)
@@ -55 +65 @@
 }
 
+/** Free TLS variant II data structures of a thread.
+ *
+ * Only static model is supported.
+ *
+ * @param tcb Pointer to TCB structure.
+ * @param size Size of thread local data.
+ */
 void __free_tls_arch(tcb_t *tcb, size_t size)
 {
-        void *start = ((void *)tcb) - size;
+        void *start = ((void *) tcb) - size;
         free(start);
 }