Changes in uspace/lib/usbdev/src/devdrv.c [065064e6:70452dd4] in mainline

File:

• uspace/lib/usbdev/src/devdrv.c (modified) (12 diffs)

uspace/lib/usbdev/src/devdrv.c

@@ -41 +41 @@
 #include <assert.h>
 
-static int generic_device_add(ddf_dev_t *);
-static int generic_device_remove(ddf_dev_t *);
-static int generic_device_gone(ddf_dev_t *);
+static int generic_add_device(ddf_dev_t *);
 
 static driver_ops_t generic_driver_ops = {
-        .add_device = generic_device_add,
-        .dev_remove = generic_device_remove,
-        .dev_gone = generic_device_gone,
+        .add_device = generic_add_device
 };
 static driver_t generic_driver = {
@@ -54 +50 @@
 };
 
-static const usb_driver_t *driver = NULL;
+static usb_driver_t *driver = NULL;
 
 
@@ -115 +111 @@
         int rc = usb_device_create_pipes(dev->ddf_dev, &dev->wire, endpoints,
             dev->descriptors.configuration, dev->descriptors.configuration_size,
-            dev->interface_no, alternate_setting, &pipes, &pipes_count);
+            dev->interface_no, alternate_setting,
+            &pipes, &pipes_count);
 
         if (rc != EOK) {
@@ -126 +123 @@
         return EOK;
 }
-/*----------------------------------------------------------------------------*/
-/** Callback when a new device is supposed to be controlled by this driver.
- *
- * This callback is a wrapper for USB specific version of @c device_add.
+
+/** Callback when new device is supposed to be controlled by this driver.
+ *
+ * This callback is a wrapper for USB specific version of @c add_device.
  *
  * @param gen_dev Device structure as prepared by DDF.
  * @return Error code.
  */
-int generic_device_add(ddf_dev_t *gen_dev)
+int generic_add_device(ddf_dev_t *gen_dev)
 {
         assert(driver);
         assert(driver->ops);
-        assert(driver->ops->device_add);
+        assert(driver->ops->add_device);
 
         int rc;
@@ -150 +147 @@
                 return rc;
         }
-        gen_dev->driver_data = dev;
-
-        rc = driver->ops->device_add(dev);
-        if (rc != EOK)
-                usb_device_destroy(dev);
-        return rc;
-}
-/*----------------------------------------------------------------------------*/
-/** Callback when a device is supposed to be removed from the system.
- *
- * This callback is a wrapper for USB specific version of @c device_remove.
- *
- * @param gen_dev Device structure as prepared by DDF.
- * @return Error code.
- */
-int generic_device_remove(ddf_dev_t *gen_dev)
-{
-        assert(driver);
-        assert(driver->ops);
-        if (driver->ops->device_rem == NULL)
-                return ENOTSUP;
-        /* Just tell the driver to stop whatever it is doing, keep structures */
-        return driver->ops->device_rem(gen_dev->driver_data);
-}
-/*----------------------------------------------------------------------------*/
-/** Callback when a device was removed from the system.
- *
- * This callback is a wrapper for USB specific version of @c device_gone.
- *
- * @param gen_dev Device structure as prepared by DDF.
- * @return Error code.
- */
-int generic_device_gone(ddf_dev_t *gen_dev)
-{
-        assert(driver);
-        assert(driver->ops);
-        if (driver->ops->device_gone == NULL)
-                return ENOTSUP;
-        usb_device_t *usb_dev = gen_dev->driver_data;
-        const int ret = driver->ops->device_gone(usb_dev);
-        if (ret == EOK)
-                usb_device_destroy(usb_dev);
-
-        return ret;
-}
-/*----------------------------------------------------------------------------*/
+
+        return driver->ops->add_device(dev);
+}
+
 /** Destroy existing pipes of a USB device.
  *
@@ -320 +275 @@
  * @return Error code.
  */
-int usb_device_create_pipes(const ddf_dev_t *dev, usb_device_connection_t *wire,
+int usb_device_create_pipes(ddf_dev_t *dev, usb_device_connection_t *wire,
     usb_endpoint_description_t **endpoints,
-    const uint8_t *config_descr, size_t config_descr_size,
+    uint8_t *config_descr, size_t config_descr_size,
     int interface_no, int interface_setting,
     usb_endpoint_mapping_t **pipes_ptr, size_t *pipes_count_ptr)
@@ -336 +291 @@
         int rc;
 
-        const size_t pipe_count = count_other_pipes(endpoints);
+        size_t pipe_count = count_other_pipes(endpoints);
         if (pipe_count == 0) {
-                *pipes_count_ptr = pipe_count;
                 *pipes_ptr = NULL;
                 return EOK;
@@ -395 +349 @@
         }
 
-        if (usb_hc_connection_close(&hc_conn) != EOK)
-                usb_log_warning("usb_device_create_pipes(): "
-                    "Failed to close connection.\n");
+        usb_hc_connection_close(&hc_conn);
 
         *pipes_ptr = pipes;
@@ -419 +371 @@
         }
 
-        if (usb_hc_connection_close(&hc_conn) != EOK)
-                usb_log_warning("usb_device_create_pipes(): "
-                    "Failed to close connection.\n");
+        usb_hc_connection_close(&hc_conn);
 
         /*
@@ -445 +395 @@
  * @param[in] pipes_count Number of endpoints.
  */
-int usb_device_destroy_pipes(const ddf_dev_t *dev,
+int usb_device_destroy_pipes(ddf_dev_t *dev,
     usb_endpoint_mapping_t *pipes, size_t pipes_count)
 {
         assert(dev != NULL);
+        assert(((pipes != NULL) && (pipes_count > 0))
+            || ((pipes == NULL) && (pipes_count == 0)));
 
         if (pipes_count == 0) {
-                assert(pipes == NULL);
                 return EOK;
         }
-        assert(pipes != NULL);
 
         int rc;
@@ -472 +422 @@
         size_t i;
         for (i = 0; i < pipes_count; i++) {
-                usb_log_debug2("Unregistering pipe %zu (%spresent).\n",
-                    i, pipes[i].present ? "" : "not ");
-                if (pipes[i].present)
-                        usb_pipe_unregister(pipes[i].pipe, &hc_conn);
+                usb_pipe_unregister(pipes[i].pipe, &hc_conn);
                 free(pipes[i].pipe);
         }
 
-        if (usb_hc_connection_close(&hc_conn) != EOK)
-                usb_log_warning("usb_device_destroy_pipes(): "
-                    "Failed to close connection.\n");
+        usb_hc_connection_close(&hc_conn);
 
         free(pipes);
@@ -599 +544 @@
 
         /* Ignore errors and hope for the best. */
-        destroy_current_pipes(dev);
+        usb_device_destroy_pipes(dev->ddf_dev, dev->pipes, dev->pipes_count);
+        if (dev->descriptors.configuration != NULL) {
+                free(dev->descriptors.configuration);
+        }
 
         if (dev->alternate_interfaces != NULL) {
-                free(dev->alternate_interfaces->alternatives);
-        }
-        free(dev->alternate_interfaces);
-        free(dev->descriptors.configuration);
-        free(dev->driver_data);
-}
-
-void * usb_device_data_alloc(usb_device_t *usb_dev, size_t size)
-{
-        assert(usb_dev);
-        assert(usb_dev->driver_data == NULL);
-        return usb_dev->driver_data = calloc(1, size);
-
+                if (dev->alternate_interfaces->alternatives != NULL) {
+                        free(dev->alternate_interfaces->alternatives);
+                }
+                free(dev->alternate_interfaces);
+        }
+
+        free(dev);
 }