Changeset 6aae539d in mainline


Ignore:
Timestamp:
2012-04-23T14:00:43Z (12 years ago)
Author:
Martin Decky <martin@…>
Branches:
lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export
Children:
32fef47, 6773ff3
Parents:
f7cbc6f
Message:

rename IPC_M_CONNECT_ME to IPC_M_CLONE_ESTABLISH

  • the term itself should be more understandable and give more hint with respect to what is actually does
  • IPC_M_CONNECT_ME was a prefix for IPC_M_CONNECT_ME_TO which was rather inconvenient
  • small documentation and cstyle improvements
Files:
8 edited

Legend:

Unmodified
Added
Removed

  • abi/include/ipc/methods.h

    rf7cbc6f r6aae539d  
    7272#define IPC_M_CONNECTION_CLONE  1
    7373
    74 /** Protocol for CONNECT - ME
     74/** Protocol for establishing a cloned connection.
    7575 *
    7676 * Through this call, the recipient learns about the new cloned connection.
    … …  
    8181 *
    8282 */
    83 #define IPC_M_CONNECT_ME  2
    84 
    85 /** Protocol for CONNECT - TO - ME
     83#define IPC_M_CLONE_ESTABLISH  2
     84
     85/** Protocol for initializing callback connections.
    8686 *
    8787 * Calling process asks the callee to create a callback connection,
    … …  
    102102#define IPC_M_CONNECT_TO_ME  3
    103103
    104 /** Protocol for CONNECT - ME - TO
     104/** Protocol for initializing new foward connections.
    105105 *
    106106 * Calling process asks the callee to create for him a new connection.
    … …  
    183183 * - ARG1 - recipient's phone to the third party task
    184184 */
    185 #define IPC_M_STATE_CHANGE_AUTHORIZE    9
     185#define IPC_M_STATE_CHANGE_AUTHORIZE  9
    186186
    187187/** Debug the recipient.
    … …  
    190190 *
    191191 */
    192 #define IPC_M_DEBUG 10
     192#define IPC_M_DEBUG  10
    193193
    194194/** Last system IPC method */

  • kernel/generic/src/ipc/sysipc.c

    rf7cbc6f r6aae539d  
    111111        switch (imethod) {
    112112        case IPC_M_CONNECTION_CLONE:
    113         case IPC_M_CONNECT_ME:
     113        case IPC_M_CLONE_ESTABLISH:
    114114        case IPC_M_PHONE_HUNGUP:
    115115                /* This message is meant only for the original recipient. */
    … …  
    160160        switch (IPC_GET_IMETHOD(call->data)) {
    161161        case IPC_M_CONNECTION_CLONE:
    162         case IPC_M_CONNECT_ME:
     162        case IPC_M_CLONE_ESTABLISH:
    163163        case IPC_M_CONNECT_TO_ME:
    164164        case IPC_M_CONNECT_ME_TO:
    … …  
    225225                        mutex_unlock(&phone->lock);
    226226                }
    227         } else if (IPC_GET_IMETHOD(*olddata) == IPC_M_CONNECT_ME) {
     227        } else if (IPC_GET_IMETHOD(*olddata) == IPC_M_CLONE_ESTABLISH) {
    228228                phone_t *phone = (phone_t *) IPC_GET_ARG5(*olddata);
    229229               
    … …  
    459459                break;
    460460        }
    461         case IPC_M_CONNECT_ME:
     461        case IPC_M_CLONE_ESTABLISH:
    462462                IPC_SET_ARG5(call->data, (sysarg_t) phone);
    463463                break;

  • uspace/app/trace/ipc_desc.c

    rf7cbc6f r6aae539d  
    3939ipc_m_desc_t ipc_methods[] = {
    4040        /* System methods */
    41         { IPC_M_PHONE_HUNGUP,  "PHONE_HUNGUP" },
    42         { IPC_M_CONNECT_ME,    "CONNECT_ME" },
    43         { IPC_M_CONNECT_ME_TO, "CONNECT_ME_TO" },
    44         { IPC_M_CONNECT_TO_ME, "CONNECT_TO_ME" },
    45         { IPC_M_SHARE_OUT,     "SHARE_OUT" },
    46         { IPC_M_SHARE_IN,      "SHARE_IN" },
    47         { IPC_M_DATA_WRITE,    "DATA_WRITE" },
    48         { IPC_M_DATA_READ,     "DATA_READ" },
    49         { IPC_M_DEBUG,         "DEBUG" },
     41        { IPC_M_PHONE_HUNGUP,     "PHONE_HUNGUP" },
     42        { IPC_M_CONNECTION_CLONE, "CONNECTION_CLONE" },
     43        { IPC_M_CLONE_ESTABLISH,  "CLONE_ESTABLISH" },
     44        { IPC_M_CONNECT_ME_TO,    "CONNECT_ME_TO" },
     45        { IPC_M_CONNECT_TO_ME,    "CONNECT_TO_ME" },
     46        { IPC_M_SHARE_OUT,        "SHARE_OUT" },
     47        { IPC_M_SHARE_IN,         "SHARE_IN" },
     48        { IPC_M_DATA_WRITE,       "DATA_WRITE" },
     49        { IPC_M_DATA_READ,        "DATA_READ" },
     50        { IPC_M_DEBUG,            "DEBUG" },
    5051       
    5152        /* Terminating entry */

  • uspace/lib/c/generic/async.c

    rf7cbc6f r6aae539d  
    946946       
    947947        switch (IPC_GET_IMETHOD(*call)) {
    948         case IPC_M_CONNECT_ME:
     948        case IPC_M_CLONE_ESTABLISH:
    949949        case IPC_M_CONNECT_ME_TO:
    950950                /* Open new connection with fibril, etc. */
    … …  
    16681668}
    16691669
    1670 /** Wrapper for making IPC_M_CONNECT_ME calls using the async framework.
    1671  *
    1672  * Ask through for a cloned connection to some service.
     1670/** Wrapper for making IPC_M_CLONE_ESTABLISH calls using the async framework.
     1671 *
     1672 * Ask for a cloned connection to some service.
    16731673 *
    16741674 * @param mgmt Exchange management style.
    … …  
    16781678 *
    16791679 */
    1680 async_sess_t *async_connect_me(exch_mgmt_t mgmt, async_exch_t *exch)
     1680async_sess_t *async_clone_establish(exch_mgmt_t mgmt, async_exch_t *exch)
    16811681{
    16821682        if (exch == NULL) {
    … …  
    17031703        msg->wdata.active = true;
    17041704       
    1705         ipc_call_async_0(exch->phone, IPC_M_CONNECT_ME, msg,
     1705        ipc_call_async_0(exch->phone, IPC_M_CLONE_ESTABLISH, msg,
    17061706            reply_received, true);
    17071707       

  • uspace/lib/c/generic/ipc.c

    rf7cbc6f r6aae539d  
    647647 *
    648648 */
    649 int ipc_connect_me(int phoneid)
     649int ipc_clone_establish(int phoneid)
    650650{
    651651        sysarg_t newphid;
    652         int res = ipc_call_sync_0_5(phoneid, IPC_M_CONNECT_ME, NULL, NULL,
    653             NULL, NULL, &newphid);
     652        int res = ipc_call_sync_0_5(phoneid, IPC_M_CLONE_ESTABLISH, NULL,
     653            NULL, NULL, NULL, &newphid);
    654654        if (res)
    655655                return res;

  • uspace/lib/c/include/async.h

    rf7cbc6f r6aae539d  
    321321    sysarg_t *, sysarg_t *);
    322322
    323 extern async_sess_t *async_connect_me(exch_mgmt_t, async_exch_t *);
     323extern async_sess_t *async_clone_establish(exch_mgmt_t, async_exch_t *);
    324324extern async_sess_t *async_connect_me_to(exch_mgmt_t, async_exch_t *, sysarg_t,
    325325    sysarg_t, sysarg_t);

  • uspace/lib/c/include/ipc/ipc.h

    rf7cbc6f r6aae539d  
    254254    sysarg_t, sysarg_t, void *, ipc_async_callback_t, bool);
    255255
     256extern int ipc_clone_establish(int);
    256257extern int ipc_connect_to_me(int, sysarg_t, sysarg_t, sysarg_t, task_id_t *,
    257258    sysarg_t *);
    258 extern int ipc_connect_me(int);
    259259extern int ipc_connect_me_to(int, sysarg_t, sysarg_t, sysarg_t);
    260260extern int ipc_connect_me_to_blocking(int, sysarg_t, sysarg_t, sysarg_t);

  • uspace/lib/fs/libfs.c

    rf7cbc6f r6aae539d  
    404404       
    405405        async_exch_t *exch = async_exchange_begin(mountee_sess);
    406         async_sess_t *sess = async_connect_me(EXCHANGE_PARALLEL, exch);
     406        async_sess_t *sess = async_clone_establish(EXCHANGE_PARALLEL, exch);
    407407       
    408408        if (!sess) {
Note: See TracChangeset for help on using the changeset viewer.