Changes in kernel/generic/src/console/kconsole.c [583c2a3:690ad20] in mainline

File:

• kernel/generic/src/console/kconsole.c (modified) (10 diffs)

kernel/generic/src/console/kconsole.c

@@ -39 +39 @@
  */
 
+#include <adt/list.h>
+#include <arch.h>
 #include <assert.h>
-#include <console/kconsole.h>
-#include <console/console.h>
 #include <console/chardev.h>
 #include <console/cmd.h>
+#include <console/console.h>
+#include <console/kconsole.h>
 #include <console/prompt.h>
+#include <debug.h>
+#include <errno.h>
+#include <halt.h>
+#include <macros.h>
+#include <panic.h>
 #include <stdio.h>
-#include <panic.h>
+#include <stdlib.h>
+#include <str.h>
+#include <symtab.h>
+#include <sysinfo/sysinfo.h>
 #include <typedefs.h>
-#include <adt/list.h>
-#include <arch.h>
-#include <macros.h>
-#include <debug.h>
-#include <halt.h>
-#include <str.h>
-#include <sysinfo/sysinfo.h>
-#include <symtab.h>
-#include <errno.h>
-#include <putchar.h>
-#include <stdlib.h>
 
 /** Simple kernel console.
@@ -85 +84 @@
 SPINLOCK_INITIALIZE(cmd_lock);  /**< Lock protecting command list. */
 LIST_INITIALIZE(cmd_list);      /**< Command list. */
+
+#define MAX_SYMBOL_NAME 64
 
 static char32_t history[KCONSOLE_HISTORY][MAX_CMDLINE] = { };
@@ -156 +157 @@
 
 /** Print count times a character */
-_NO_TRACE static void print_cc(char32_t ch, size_t count)
-{
-        size_t i;
-        for (i = 0; i < count; i++)
-                putuchar(ch);
+_NO_TRACE static void print_cc(char ch, size_t count)
+{
+        // FIXME: only lock once
+
+        for (size_t i = 0; i < count; i++)
+                putstr(&ch, 1);
 }
 
@@ -345 +347 @@
                 if (ch == '\n') {
                         /* Enter */
-                        putuchar(ch);
+                        putstr("\n", 1);
                         break;
                 }
@@ -356 +358 @@
                         if (wstr_remove(current, position - 1)) {
                                 position--;
-                                putuchar('\b');
+                                putstr("\b", 1);
                                 printf("%ls ", current + position);
                                 print_cc('\b', wstr_length(current) - position + 1);
@@ -366 +368 @@
                         /* Tab completion */
 
-                        /* Move to the end of the word */
-                        for (; (current[position] != 0) && (!isspace(current[position]));
-                            position++)
-                                putuchar(current[position]);
+                        size_t i = position;
+                        while (current[i] && !isspace(current[i]))
+                                i++;
+
+                        char32_t stash = current[i];
+                        current[i] = 0;
+                        printf("%ls", &current[position]);
+                        current[i] = stash;
+                        position = i;
 
                         /*
@@ -428 +435 @@
                          */
                         size_t off = 0;
-                        size_t i = 0;
-                        while ((ch = str_decode(tmp, &off, STR_NO_LIMIT)) != 0) {
+                        for (size_t i = 0; (ch = str_decode(tmp, &off, STR_NO_LIMIT)); i++)
                                 if (!wstr_linsert(current, ch, position + i, MAX_CMDLINE))
                                         break;
-
-                                i++;
-                        }
 
                         if (found > 1) {
@@ -464 +467 @@
                         /* Left */
                         if (position > 0) {
-                                putuchar('\b');
+                                putstr("\b", 1);
                                 position--;
                         }
@@ -473 +476 @@
                         /* Right */
                         if (position < wstr_length(current)) {
-                                putuchar(current[position]);
+                                printf("%lc", current[position]);
                                 position++;
                         }
@@ -597 +600 @@
                 /* It's a number - convert it */
                 uint64_t value;
-                char *end;
+                const char *end;
                 errno_t rc = str_uint64_t(text, &end, 0, false, &value);
                 if (end != text + len)