Changeset 62721d5 in mainline

Timestamp:

2023-10-22T16:45:25Z (14 months ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

master, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

8f9f9b1

Parents:

b7493ea0

git-author:

Vojtech Horky <vojtech.horky@…> (2023-07-14 13:58:38)

git-committer:

Jiří Zárevúcky <zarevucky.jiri@…> (2023-10-22 16:45:25)

Message:

Workaround linker warnings about RWX segment

Files:

• kernel/meson.build (modified) (1 diff)
• meson/arch/arm64/meson.build (modified) (1 diff)
• meson/arch/ia64/meson.build (modified) (1 diff)
• meson/arch/ppc32/meson.build (modified) (1 diff)
• meson/arch/riscv64/meson.build (modified) (1 diff)
• meson/part/compiler_args/meson.build (modified) (1 diff)

kernel/meson.build

@@ -89 +89 @@
         '-T', meson.current_build_dir() / '_link.ld',
 ]
+# The kernel is built as ELF but then copied as a blob of bytes and
+# the permissions are not relevant anyway (needed for binutils 2.39+).
+kernel_link_args += ldflags_ignore_rwx_segments
 
 if CONFIG_LTO

meson/arch/arm64/meson.build

@@ -48 +48 @@
 # -mstrict-align option is therefore not needed.
 arch_boot_c_args = arch_uspace_c_args + [ '-fpic', '-fvisibility=hidden', '-fno-function-sections' ]
-arch_boot_link_args = [ '-Wl,-shared', '-Wl,--no-gc-sections' ]
+arch_boot_link_args = [ '-Wl,-shared', '-Wl,--no-gc-sections' ] + ldflags_ignore_rwx_segments
 
 if MACHINE == 'virt'

meson/arch/ia64/meson.build

@@ -38 +38 @@
 arch_uspace_link_args = [ '-nostdlib', '-lgcc' ]
 arch_kernel_link_args = [ '-nostdlib', '-Wl,-EL' ]
-arch_boot_link_args = []
+arch_boot_link_args = ldflags_ignore_rwx_segments
 
 

meson/arch/ppc32/meson.build

@@ -37 +37 @@
 arch_kernel_link_args = [ '-nostdlib', '-Wl,-z,max-page-size=0x1000', '-Wl,--no-check-sections', '-Wl,--no-gc-sections' ]
 arch_uspace_link_args = [ '-nostdlib', '-lgcc', '-Wl,-z,max-page-size=0x1000' ]
-arch_boot_link_args = []
+arch_uspace_link_args += ldflags_ignore_rwx_segments
+arch_boot_link_args = ldflags_ignore_rwx_segments
 
 rd_essential += [

meson/arch/riscv64/meson.build

@@ -33 +33 @@
 arch_kernel_link_args = [ '-nostdlib' ]
 arch_uspace_link_args = [ '-nostdlib', '-lgcc' ]
-arch_boot_link_args = []
+arch_boot_link_args = ldflags_ignore_rwx_segments
 
 rd_essential += [

meson/part/compiler_args/meson.build

@@ -128 +128 @@
         add_project_link_arguments(extra_cflags, language : [ lang ])
 endforeach
+
+# This flag is needed at several places, hence we define it here.
+#
+# For backwards compatibility we try to detect --no-warn-rwx-segments.
+# However, the autodetection done by Meson also results in
+# "cannot find entry symbol _start; defaulting to 00000000004000b0"
+# thus the option is never supported alone. So when detecting we also
+# specify --entry=main so that the stub source provided by Meson is build
+# correctly.
+ldflags_ignore_rwx_segments = []
+if cc.has_link_argument('-Wl,--no-warn-rwx-segments,--entry=main')
+    ldflags_ignore_rwx_segments += ['-Wl,--no-warn-rwx-segments']
+endif