Changeset 566da7f8 in mainline

Timestamp:

2014-04-24T06:47:53Z (10 years ago)

Author:

Vojtech Horky <vojtechhorky@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

e36a1c2

Parents:

88a0f58

Message:

Fix another bunch of maybe-uninitialized warnings

Location:

kernel

Files:

• arch/sparc64/src/drivers/kbd.c (modified) (1 diff)
• arch/sparc64/src/smp/sun4v/smp.c (modified) (1 diff)
• generic/src/console/cmd.c (modified) (1 diff)
• generic/src/mm/as.c (modified) (2 diffs)
• generic/src/mm/frame.c (modified) (1 diff)

kernel/arch/sparc64/src/drivers/kbd.c

@@ -90 +90 @@
         size_t size = ((ofw_ebus_reg_t *) prop->value)->size;
         
-        uintptr_t pa;
+        uintptr_t pa = 0; // Prevent -Werror=maybe-uninitialized
         if (!ofw_ebus_apply_ranges(node->parent,
             ((ofw_ebus_reg_t *) prop->value), &pa)) {

kernel/arch/sparc64/src/smp/sun4v/smp.c

@@ -263 +263 @@
                 while (md_next_child(&it)) {
                         md_node_t child = md_get_child_node(it);
-                        const char *exec_unit_type;
+                        const char *exec_unit_type = "";
                         md_get_string_property(child, "type", &exec_unit_type);
 

kernel/generic/src/console/cmd.c

@@ -1149 +1149 @@
 int cmd_set4(cmd_arg_t *argv)
 {
-        uintptr_t addr;
+        uintptr_t addr = 0; // Prevent -Werror=maybe-uninitialized
         uint32_t arg1 = argv[1].intval;
         bool pointer = false;

kernel/generic/src/mm/as.c

@@ -1725 +1725 @@
         ASSERT(count);
         
-        btree_node_t *leaf;
+        btree_node_t *leaf = NULL;
         size_t pages = (size_t) btree_search(&area->used_space, page, &leaf);
         if (pages) {
@@ -1733 +1733 @@
                 return false;
         }
+
+        ASSERT(leaf != NULL);
         
         if (!leaf->keys) {

kernel/generic/src/mm/frame.c

@@ -391 +391 @@
         
         /* Allocate frames from zone */
-        size_t index;
+        size_t index = (size_t) -1;
         int avail = bitmap_allocate_range(&zone->bitmap, count, zone->base,
             FRAME_LOWPRIO, constraint, &index);
         
         ASSERT(avail);
+        ASSERT(index != (size_t) -1);
         
         /* Update frame reference count */