Changeset 5441670 in mainline

Timestamp:

2014-09-12T13:53:24Z (11 years ago)

Author:

Martin Decky <martin@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

662ebc8

Parents:

105d8d6

Message:

fix TCP locking issue and crash
connection needs to be locked before tcp_conn_sync() is called

File:

• uspace/srv/net/tcp/ucall.c (modified) (3 diffs)

uspace/srv/net/tcp/ucall.c

@@ -76 +76 @@
         nconn = tcp_conn_new(lsock, fsock);
         tcp_conn_add(nconn);
+        tcp_conn_lock(nconn);
 
         if (acpass == ap_active) {
@@ -83 +84 @@
 
         if (oflags == tcp_open_nonblock) {
+                tcp_conn_unlock(nconn);
                 log_msg(LOG_DEFAULT, LVL_DEBUG, "tcp_uc_open -> %p", nconn);
                 *conn = nconn;
@@ -90 +92 @@
         /* Wait for connection to be established or reset */
         log_msg(LOG_DEFAULT, LVL_DEBUG, "tcp_uc_open: Wait for connection.");
-        tcp_conn_lock(nconn);
         while (nconn->cstate == st_listen ||
             nconn->cstate == st_syn_sent ||