Changeset 53a309e in mainline

Timestamp:

2017-10-08T20:42:50Z (7 years ago)

Author:

Jiri Svoboda <jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

07cb0108

Parents:

d15797d

Message:

Must not explicitly close DDF-provided parent session.

Location:

uspace/drv

Files:

• audio/sb16/dsp.c (modified) (2 diffs)
• audio/sb16/main.c (modified) (2 diffs)
• bus/usb/ehci/res.c (modified) (1 diff)
• bus/usb/uhci/main.c (modified) (1 diff)

uspace/drv/audio/sb16/dsp.c

@@ -163 +163 @@
         async_sess_t *sess = ddf_dev_parent_sess_get(dsp->sb_dev);
 
-        const int ret = hw_res_dma_channel_setup(sess,
+        return hw_res_dma_channel_setup(sess,
             dsp->dma16_channel, pa, size,
             DMA_MODE_READ | DMA_MODE_AUTO | DMA_MODE_ON_DEMAND);
-
-        async_hangup(sess);
-        return ret;
 }
 
@@ -307 +304 @@
         // TODO: Assumes DMA 16
         const int remain = hw_res_dma_channel_remain(sess, dsp->dma16_channel);
-        async_hangup(sess);
         if (remain >= 0) {
                 *pos = dsp->buffer.size - remain;

uspace/drv/audio/sb16/main.c

@@ -186 +186 @@
         hw_res_list_parsed_init(&hw_res);
         const int ret = hw_res_get_list_parsed(parent_sess, &hw_res, 0);
-        async_hangup(parent_sess);
         if (ret != EOK) {
                 return ret;
@@ -250 +249 @@
 
         bool enabled = hw_res_enable_interrupt(parent_sess);
-        async_hangup(parent_sess);
 
         return enabled ? EOK : EIO;

uspace/drv/bus/usb/ehci/res.c

@@ -229 +229 @@
         //TODO unmap registers
         hw_res_list_parsed_clean(&res);
-        async_hangup(parent_sess);
         return ret;
 }

uspace/drv/bus/usb/uhci/main.c

@@ -111 +111 @@
         /* See UHCI design guide page 45 for these values.
          * Write all WC bits in USB legacy register */
-        const int rc = pci_config_space_write_16(parent_sess, 0xc0, 0xaf00);
-
-        async_hangup(parent_sess);
-        return rc;
+        return pci_config_space_write_16(parent_sess, 0xc0, 0xaf00);
 }