Changeset 52be5fa in mainline

Timestamp:

2025-04-01T10:02:37Z (3 months ago)

Author:

Miroslav Cimerman <mc@…>

Children:

bbcd06e

Parents:

c7e6a3e

Message:

hr: increment metadata counter on volume assembly

For now increment the metadata counter right on assembly, but in the
future it can be deferred until the first write I/O comes our way,
to allow "read-only assembly" of volumes.

Location:

uspace/srv/bd/hr

Files:

• superblock.c (modified) (1 diff)
• util.c (modified) (1 diff)

uspace/srv/bd/hr/superblock.c

@@ -87 +87 @@
 }
 
+/*
+ * TODO: think about thread safety, if hr_metadata_save() can
+ * be called from multiple threads, and if, maybe will need
+ * md_lock... or whatever, but dont want to stall I/Os...
+ */
 errno_t hr_metadata_save(hr_volume_t *vol)
 {

uspace/srv/bd/hr/util.c

@@ -823 +823 @@
         }
 
+        /*
+         * TODO: something like mark md dirty or whatever, just sync the
+         * vol->counter with vol->in_mem_md->counter, or merge them and only
+         * keep the vol->in_mem_md->counter...
+         *
+         * XXX: if thats the only thing that can change in metadata
+         * during volume runtime, then whatever, but if more
+         * things will need to be synced, think of something more clever
+         *
+         * TODO: remove from here and increment it the "first" time (if nothing
+         * happens - no state changes, no rebuild, etc) - only after the first
+         * write... but for now leave it here
+         */
+        vol->counter++;
+        vol->in_mem_md->counter = vol->counter;
+
+        hr_metadata_save(vol);
+
         rc = vol->hr_ops.create(vol);
         if (rc != EOK)