Changes in uspace/drv/bus/usb/uhci/pci.c [45a9cf4:5203e256] in mainline

File:

• uspace/drv/bus/usb/uhci/pci.c (modified) (6 diffs)

uspace/drv/bus/usb/uhci/pci.c

@@ -61 +61 @@
         assert(io_reg_size);
         assert(irq_no);
-
+        
         async_sess_t *parent_sess =
             devman_parent_device_connect(EXCHANGE_SERIALIZE, dev->handle,
@@ -67 +67 @@
         if (!parent_sess)
                 return ENOMEM;
-
+        
         hw_resource_list_t hw_resources;
-        const int rc = hw_res_get_resource_list(parent_sess, &hw_resources);
-        async_hangup(parent_sess);
+        int rc = hw_res_get_resource_list(parent_sess, &hw_resources);
         if (rc != EOK) {
+                async_hangup(parent_sess);
                 return rc;
         }
-
+        
         uintptr_t io_address = 0;
         size_t io_size = 0;
         bool io_found = false;
-
+        
         int irq = 0;
         bool irq_found = false;
-
+        
         size_t i;
         for (i = 0; i < hw_resources.count; i++) {
@@ -102 +102 @@
                 }
         }
-        free(hw_resources.resources);
-
+        
+        async_hangup(parent_sess);
+        
         if (!io_found || !irq_found)
                 return ENOENT;
-
+        
         *io_reg_address = io_address;
         *io_reg_size = io_size;
         *irq_no = irq;
-
+        
         return EOK;
 }
-/*----------------------------------------------------------------------------*/
+
 /** Call the PCI driver with a request to enable interrupts
  *
@@ -126 +127 @@
         if (!parent_sess)
                 return ENOMEM;
-
+        
         const bool enabled = hw_res_enable_interrupt(parent_sess);
         async_hangup(parent_sess);
-
+        
         return enabled ? EOK : EIO;
 }
-/*----------------------------------------------------------------------------*/
+
 /** Call the PCI driver with a request to clear legacy support register
  *
@@ -141 +142 @@
 {
         assert(device);
-
+        
         async_sess_t *parent_sess =
             devman_parent_device_connect(EXCHANGE_SERIALIZE, device->handle,
@@ -147 +148 @@
         if (!parent_sess)
                 return ENOMEM;
-
+        
         /* See UHCI design guide for these values p.45,
          * write all WC bits in USB legacy register */
         const sysarg_t address = 0xc0;
         const sysarg_t value = 0xaf00;
-
+        
         async_exch_t *exch = async_exchange_begin(parent_sess);
-
+        
         const int rc = async_req_3_0(exch, DEV_IFACE_ID(PCI_DEV_IFACE),
             IPC_M_CONFIG_SPACE_WRITE_16, address, value);
-
+        
         async_exchange_end(exch);
         async_hangup(parent_sess);
-
+        
         return rc;
 }