Changes in uspace/drv/uhci-hcd/transfer_list.c [4c70554:4fd3faf] in mainline

File:

• uspace/drv/uhci-hcd/transfer_list.c (modified) (11 diffs)

uspace/drv/uhci-hcd/transfer_list.c

@@ -57 +57 @@
                 return ENOMEM;
         }
-        uint32_t queue_head_pa = addr_to_phys(instance->queue_head);
+        instance->queue_head_pa = addr_to_phys(instance->queue_head);
         usb_log_debug2("Transfer list %s setup with QH: %p(%p).\n",
-            name, instance->queue_head, queue_head_pa);
+            name, instance->queue_head, instance->queue_head_pa);
 
         qh_init(instance->queue_head);
@@ -67 +67 @@
 }
 /*----------------------------------------------------------------------------*/
-/** Dispose transfer list structures.
- *
- * @param[in] instance Memory place to use.
- *
- * Frees memory for internal qh_t structure.
- */
-void transfer_list_fini(transfer_list_t *instance)
-{
-        assert(instance);
-        free32(instance->queue_head);
-}
 /** Set the next list in transfer list chain.
  *
@@ -92 +81 @@
         if (!instance->queue_head)
                 return;
-        /* Set queue_head.next to point to the follower */
-        qh_set_next_qh(instance->queue_head, next->queue_head);
-}
-/*----------------------------------------------------------------------------*/
-/** Add transfer batch to the list and queue.
+        /* Set both queue_head.next to point to the follower */
+        qh_set_next_qh(instance->queue_head, next->queue_head_pa);
+}
+/*----------------------------------------------------------------------------*/
+/** Submit transfer batch to the list and queue.
  *
  * @param[in] instance List to use.
  * @param[in] batch Transfer batch to submit.
+ * @return Error code
  *
  * The batch is added to the end of the list and queue.
@@ -119 +109 @@
         } else {
                 /* There is something scheduled */
-                usb_transfer_batch_t *last =
-                    usb_transfer_batch_from_link(instance->batch_list.prev);
+                usb_transfer_batch_t *last = list_get_instance(
+                    instance->batch_list.prev, usb_transfer_batch_t, link);
                 last_qh = batch_qh(last);
         }
@@ -128 +118 @@
         /* keep link */
         batch_qh(batch)->next = last_qh->next;
-        qh_set_next_qh(last_qh, batch_qh(batch));
+        qh_set_next_qh(last_qh, pa);
 
         asm volatile ("": : :"memory");
@@ -142 +132 @@
 }
 /*----------------------------------------------------------------------------*/
-/** Add completed bantches to the provided list.
+/** Create list for finished batches.
  *
  * @param[in] instance List to use.
@@ -157 +147 @@
                 link_t *next = current->next;
                 usb_transfer_batch_t *batch =
-                    usb_transfer_batch_from_link(current);
+                    list_get_instance(current, usb_transfer_batch_t, link);
 
                 if (batch_is_complete(batch)) {
-                        /* Save for processing */
+                        /* Save for post-processing */
                         transfer_list_remove_batch(instance, batch);
                         list_append(current, done);
@@ -169 +159 @@
 }
 /*----------------------------------------------------------------------------*/
-/** Walk the list and finish all batches with EINTR.
+/** Walk the list and abort all batches.
  *
  * @param[in] instance List to use.
@@ -179 +169 @@
                 link_t *current = instance->batch_list.next;
                 usb_transfer_batch_t *batch =
-                    usb_transfer_batch_from_link(current);
+                    list_get_instance(current, usb_transfer_batch_t, link);
                 transfer_list_remove_batch(instance, batch);
-                usb_transfer_batch_finish_error(batch, EINTR);
+                usb_transfer_batch_finish_error(batch, EIO);
         }
         fibril_mutex_unlock(&instance->guard);
@@ -190 +180 @@
  * @param[in] instance List to use.
  * @param[in] batch Transfer batch to remove.
+ * @return Error code
  *
  * Does not lock the transfer list, caller is responsible for that.
@@ -206 +197 @@
 
         const char *qpos = NULL;
-        qh_t *prev_qh = NULL;
         /* Remove from the hardware queue */
         if (instance->batch_list.next == &batch->link) {
                 /* I'm the first one here */
-                prev_qh = instance->queue_head;
+                assert((instance->queue_head->next & LINK_POINTER_ADDRESS_MASK)
+                    == addr_to_phys(batch_qh(batch)));
+                instance->queue_head->next = batch_qh(batch)->next;
                 qpos = "FIRST";
         } else {
-                /* The thing before me is a batch too */
                 usb_transfer_batch_t *prev =
-                    usb_transfer_batch_from_link(batch->link.prev);
-                prev_qh = batch_qh(prev);
+                    list_get_instance(
+                        batch->link.prev, usb_transfer_batch_t, link);
+                assert((batch_qh(prev)->next & LINK_POINTER_ADDRESS_MASK)
+                    == addr_to_phys(batch_qh(batch)));
+                batch_qh(prev)->next = batch_qh(batch)->next;
                 qpos = "NOT FIRST";
         }
-        assert((prev_qh->next & LINK_POINTER_ADDRESS_MASK)
-            == addr_to_phys(batch_qh(batch)));
-        prev_qh->next = batch_qh(batch)->next;
         asm volatile ("": : :"memory");
         /* Remove from the batch list */
         list_remove(&batch->link);
-        usb_log_debug("Batch(%p) removed (%s) from %s, next: %x.\n",
+        usb_log_debug("Batch(%p) removed (%s) from %s, next %x.\n",
             batch, qpos, instance->name, batch_qh(batch)->next);
 }