Changeset 495547d in mainline

Timestamp:

2015-07-03T23:10:21Z (9 years ago)

Author:

Jan Vesely <jano.vesely@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

cc468c7

Parents:

954d590

Message:

ehci/hc: Postpone enabling of interrupts.

Clean status register before doing so.
Helps avoid spurious interrupt on startup.

File:

• uspace/drv/bus/usb/ehci/hc.c (modified) (2 diffs)

uspace/drv/bus/usb/ehci/hc.c

@@ -397 +397 @@
         usb_log_debug("HC(%p): HW reset OK.", instance);
 
-        //TODO: Do this last
-        /* Enable interrupts */
-        EHCI_WR(instance->registers->usbintr, EHCI_USED_INTERRUPTS);
         /* Use the lowest 4G segment */
         EHCI_WR(instance->registers->ctrldssegment, 0);
@@ -435 +432 @@
             &instance->registers->usbintr, EHCI_RD(instance->registers->usbintr),
             &instance->registers->configflag, EHCI_RD(instance->registers->configflag));
+        /* Clear and Enable interrupts */
+        EHCI_WR(instance->registers->usbsts, EHCI_RD(instance->registers->usbsts));
+        EHCI_WR(instance->registers->usbintr, EHCI_USED_INTERRUPTS);
 }