Changeset 46577995 in mainline for uspace/app/nic

Timestamp:

2018-01-04T20:50:52Z (8 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Children:

e211ea04

Parents:

facacc71

git-author:

Jiří Zárevúcky <zarevucky.jiri@…> (2018-01-04 20:47:53)

git-committer:

Jiří Zárevúcky <zarevucky.jiri@…> (2018-01-04 20:50:52)

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

After this commit, HelenOS is free of code that mixes error codes with non-error
values on the assumption that error codes are negative.

File:

• uspace/app/nic/nic.c (modified) (14 diffs)

uspace/app/nic/nic.c

@@ -72 +72 @@
 static async_sess_t *get_nic_by_index(size_t i)
 {
-        int rc;
+        errno_t rc;
         size_t count;
         char *svc_name;
@@ -110 +110 @@
 }
 
-static int nic_get_info(service_id_t svc_id, char *svc_name,
+static errno_t nic_get_info(service_id_t svc_id, char *svc_name,
     nic_info_t *info)
 {
         async_sess_t *sess;
         nic_role_t role;
-        int rc;
+        errno_t rc;
 
         sess = loc_service_connect(svc_id, INTERFACE_DDF, 0);
@@ -245 +245 @@
 }
 
-static int nic_list(void)
+static errno_t nic_list(void)
 {
         category_id_t nic_cat;
@@ -253 +253 @@
         char *svc_name;
         char *addr_str;
-        int rc;
+        errno_t rc;
 
         rc = loc_category_get_id("nic", &nic_cat, 0);
@@ -316 +316 @@
 }
 
-static int nic_set_speed(int i, char *str)
+static errno_t nic_set_speed(int i, char *str)
 {
         async_sess_t *sess;
@@ -323 +323 @@
         nic_channel_mode_t oldduplex;
         nic_role_t oldrole;
-        int rc;
+        errno_t rc;
 
         rc = str_uint32_t(str, NULL, 10, false, &speed);
@@ -351 +351 @@
 }
 
-static int nic_set_duplex(int i, char *str)
+static errno_t nic_set_duplex(int i, char *str)
 {
         async_sess_t *sess;
@@ -358 +358 @@
         nic_channel_mode_t oldduplex;
         nic_role_t oldrole;
-        int rc;
+        errno_t rc;
 
         if (!str_cmp(str, "half"))
@@ -389 +389 @@
 }
 
-static int nic_set_autoneg(int i)
-{
-        async_sess_t *sess;
-        int rc;
+static errno_t nic_set_autoneg(int i)
+{
+        async_sess_t *sess;
+        errno_t rc;
 
         sess = get_nic_by_index(i);
@@ -409 +409 @@
 }
 
-static int nic_set_addr(int i, char *str)
+static errno_t nic_set_addr(int i, char *str)
 {
         async_sess_t *sess;
         nic_address_t addr;
-        int rc;
+        errno_t rc;
         int idx;
 
@@ -438 +438 @@
 }
 
-static int nic_set_rx_unicast(int i, char *str)
+static errno_t nic_set_rx_unicast(int i, char *str)
 {
         async_sess_t *sess;
@@ -473 +473 @@
 }
 
-static int nic_set_rx_multicast(int i, char *str)
+static errno_t nic_set_rx_multicast(int i, char *str)
 {
         async_sess_t *sess;
@@ -502 +502 @@
 }
 
-static int nic_set_rx_broadcast(int i, char *str)
+static errno_t nic_set_rx_broadcast(int i, char *str)
 {
         async_sess_t *sess;
@@ -528 +528 @@
 int main(int argc, char *argv[])
 {
-        int rc;
+        errno_t rc;
         uint32_t index;