Changeset 401b9e42 in mainline

Timestamp:

2025-01-12T21:53:55Z (5 months ago)

Author:

Miroslav Cimerman <mc@…>

Children:

dec4150

Parents:

e2b417f

git-author:

Miroslav Cimerman <mc@…> (2025-01-12 19:18:08)

git-committer:

Miroslav Cimerman <mc@…> (2025-01-12 21:53:55)

Message:

hr: state_changed and peding_invalidation atomic flags

These flags are used to check whether there was a state
change, or if there is a pending invalidation, so that
we can avoid the slow code paths in a lockless fashion.

Location:

uspace/srv/bd/hr

Files:

• hr.c (modified) (2 diffs)
• raid1.c (modified) (5 diffs)
• var.h (modified) (1 diff)

uspace/srv/bd/hr/hr.c

@@ -264 +264 @@
 
         atomic_init(&new_volume->rebuild_blk, 0);
+        atomic_init(&new_volume->state_changed, false);
+        atomic_init(&new_volume->pending_invalidation, false);
 
         rc = new_volume->hr_ops.create(new_volume);
@@ -320 +322 @@
                 fibril_rwlock_write_lock(&vol->states_lock);
                 fibril_rwlock_read_lock(&vol->extents_lock);
+
+                /* TODO: maybe expose extent state callbacks */
                 hr_update_ext_status(vol, fail_extent, HR_EXT_FAILED);
+                atomic_store(&vol->state_changed, true);
+
                 fibril_rwlock_read_unlock(&vol->extents_lock);
                 fibril_rwlock_write_unlock(&vol->states_lock);

uspace/srv/bd/hr/raid1.c

@@ -103 +103 @@
         new_volume->hr_bds.sarg = new_volume;
 
+        /* force volume state update */
+        atomic_store(&new_volume->state_changed, true);
         hr_raid1_update_vol_status(new_volume);
         if (new_volume->status == HR_VOL_FAULTY)
@@ -275 +277 @@
 static void hr_raid1_update_vol_status(hr_volume_t *vol)
 {
-        fibril_mutex_lock(&vol->deferred_list_lock);
-
-        if (list_count(&vol->deferred_invalidations_list) > 0)
+        bool exp = true;
+
+        if (!atomic_compare_exchange_strong(&vol->state_changed, &exp, false))
+                return;
+
+        if (atomic_compare_exchange_strong(&vol->pending_invalidation, &exp,
+            false)) {
+                fibril_mutex_lock(&vol->deferred_list_lock);
                 process_deferred_invalidations(vol);
-
-        fibril_mutex_unlock(&vol->deferred_list_lock);
+                fibril_mutex_unlock(&vol->deferred_list_lock);
+        }
 
         fibril_rwlock_read_lock(&vol->extents_lock);
@@ -344 +351 @@
                                 assert(vol->extents[extent].status ==
                                     HR_EXT_INVALID);
-                                goto done;
+                                goto deferring_end;
                         }
                 }
@@ -358 +365 @@
                 list_append(&vol->deferred_inval[i].link,
                     &vol->deferred_invalidations_list);
-        done:
+
+                atomic_store(&vol->pending_invalidation, true);
+        deferring_end:
+
                 fibril_mutex_unlock(&vol->deferred_list_lock);
                 break;
@@ -367 +377 @@
                 hr_update_ext_status(vol, extent, HR_EXT_FAILED);
         }
+
+        atomic_store(&vol->state_changed, true);
 
         fibril_rwlock_write_unlock(&vol->states_lock);

uspace/srv/bd/hr/var.h

@@ -117 +117 @@
          * are harvested later when we are able to.
          */
+        _Atomic bool pending_invalidation;
         fibril_mutex_t deferred_list_lock;
         list_t deferred_invalidations_list;
         hr_deferred_invalidation_t deferred_inval[HR_MAX_EXTENTS];
 
+        _Atomic bool state_changed;
         _Atomic uint64_t rebuild_blk;
         uint64_t counter; /* metadata syncing */