Changes in tools/config.py [3f1a481:3ef901d0] in mainline

File:

• tools/config.py (modified) (12 diffs)

tools/config.py

@@ -42 +42 @@
 import random
 
-ARGPOS_RULES = 1
-ARGPOS_PRESETS_DIR = 2
-ARGPOS_CHOICE = 3
-ARGPOS_PRESET = 4
-ARGPOS_MASK_PLATFORM = 3
-
-RULES_FILE = sys.argv[ARGPOS_RULES]
+RULES_FILE = sys.argv[1]
 MAKEFILE = 'Makefile.config'
 MACROS = 'config.h'
-PRESETS_DIR = sys.argv[ARGPOS_PRESETS_DIR]
+PRESETS_DIR = 'defaults'
 
 class BinaryOp:
@@ -538 +532 @@
 
         try:
-                version = subprocess.Popen(['git', '-C', os.path.dirname(RULES_FILE), 'log', '-1', '--pretty=%h'], stdout = subprocess.PIPE).communicate()[0].decode().strip()
+                version = subprocess.Popen(['git', 'log', '-1', '--pretty=%h'], stdout = subprocess.PIPE).communicate()[0].decode().strip()
                 sys.stderr.write("ok\n")
         except:
@@ -592 +586 @@
         outmk.write('TIMESTAMP_UNIX = %d\n' % timestamp_unix)
         outmc.write('#define TIMESTAMP_UNIX %d\n' % timestamp_unix)
-        defs += ' "-DTIMESTAMP_UNIX=%d"' % timestamp_unix
+        defs += ' "-DTIMESTAMP_UNIX=%d"\n' % timestamp_unix
 
         outmk.write('TIMESTAMP = %s\n' % timestamp)
         outmc.write('#define TIMESTAMP %s\n' % timestamp)
-        defs += ' "-DTIMESTAMP=%s"' % timestamp
-
-        outmk.write('%s\n' % defs)
+        defs += ' "-DTIMESTAMP=%s"\n' % timestamp
+
+        outmk.write(defs)
 
         outmk.close()
@@ -682 +676 @@
         parse_rules(RULES_FILE, rules)
 
-        if len(sys.argv) > ARGPOS_CHOICE:
-                choice = sys.argv[ARGPOS_CHOICE]
-        else:
-                choice = None
-
-        if len(sys.argv) > ARGPOS_PRESET:
-                preset = sys.argv[ARGPOS_PRESET]
-        else:
-                preset = None
-
-        mask_platform = (len(sys.argv) > ARGPOS_MASK_PLATFORM and sys.argv[ARGPOS_MASK_PLATFORM] == "--mask-platform")
-
         # Input configuration file can be specified on command line
         # otherwise configuration from previous run is used.
-        if preset is not None:
-                profile = parse_profile_name(preset)
+        if len(sys.argv) >= 4:
+                profile = parse_profile_name(sys.argv[3])
                 read_presets(profile, config)
         elif os.path.exists(MAKEFILE):
@@ -703 +685 @@
 
         # Default mode: check values and regenerate configuration files
-        if choice == 'default':
+        if (len(sys.argv) >= 3) and (sys.argv[2] == 'default'):
                 if (infer_verify_choices(config, rules)):
                         preprocess_config(config, rules)
@@ -711 +693 @@
         # Hands-off mode: check values and regenerate configuration files,
         # but no interactive fallback
-        if choice == 'hands-off':
-                # We deliberately test this because we do not want
+        if (len(sys.argv) >= 3) and (sys.argv[2] == 'hands-off'):
+                # We deliberately test sys.argv >= 4 because we do not want
                 # to read implicitly any possible previous run configuration
-                if preset is None:
+                if len(sys.argv) < 4:
                         sys.stderr.write("Configuration error: No presets specified\n")
                         return 2
@@ -727 +709 @@
 
         # Check mode: only check configuration
-        if choice == 'check':
+        if (len(sys.argv) >= 3) and (sys.argv[2] == 'check'):
                 if infer_verify_choices(config, rules):
                         return 0
@@ -733 +715 @@
 
         # Random mode
-        if choice == 'random':
+        if (len(sys.argv) == 3) and (sys.argv[2] == 'random'):
                 ok = random_choices(config, rules, 0)
                 if not ok:
@@ -759 +741 @@
                         options = []
                         opt2row = {}
-                        cnt = 0
-
-                        if not mask_platform:
-                                cnt += 1
-                                options.append("  --- Load preconfigured defaults ... ")
+                        cnt = 1
+
+                        options.append("  --- Load preconfigured defaults ... ")
 
                         for rule in rules:
@@ -770 +750 @@
                                 if cond and not cond.evaluate(config):
                                         continue
-
-                                if mask_platform and (varname == "PLATFORM" or varname == "MACHINE" or varname == "COMPILER"):
-                                        rule = varname, vartype, "(locked) " + name, choices, cond
 
                                 if varname == selname:
@@ -820 +797 @@
                                         continue
 
-                        if value == 0 and not mask_platform:
+                        if value == 0:
                                 profile = choose_profile(PRESETS_DIR, MAKEFILE, screen, config)
                                 if profile != None:
@@ -837 +814 @@
                         else:
                                 value = config[selname]
-
-                        if mask_platform and (selname == "PLATFORM" or selname == "MACHINE" or selname == "COMPILER"):
-                                        continue
 
                         if seltype == 'choice':