Changeset 371bd7d in mainline for kernel/generic/src/udebug

Timestamp:

2010-03-27T09:22:17Z (16 years ago)

Author:

Jiri Svoboda <jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/fix-logger-deadlock, topic/msim-upgrade, topic/simplify-dev-export

Children:

36a75a2

Parents:

cd82bb1 (diff), eaf22d4 (diff)
Note: this is a merge changeset, the changes displayed below correspond to the merge itself.
Use the (diff) links above to see all the changes relative to each parent.

Message:

Merge mainline changes.

Location:

kernel/generic/src/udebug

Files:

• udebug.c (modified) (3 diffs)
• udebug_ipc.c (modified) (6 diffs)
• udebug_ops.c (modified) (11 diffs)

kernel/generic/src/udebug/udebug.c

@@ -69 +69 @@
         mutex_initialize(&ut->lock, MUTEX_PASSIVE);
         waitq_initialize(&ut->go_wq);
+        condvar_initialize(&ut->active_cv);
 
         ut->go_call = NULL;
@@ -446 +447 @@
                                 waitq_wakeup(&t->udebug.go_wq, WAKEUP_FIRST);
                         }
+                        mutex_unlock(&t->udebug.lock);
+                        condvar_broadcast(&t->udebug.active_cv);
+                } else {
+                        mutex_unlock(&t->udebug.lock);
                 }
-                mutex_unlock(&t->udebug.lock);
         }
 
@@ -456 +460 @@
 }
 
+/** Wait for debugger to handle a fault in this thread.
+ *
+ * When a thread faults and someone is subscribed to the FAULT kernel event,
+ * this function is called to wait for a debugging session to give userspace
+ * a chance to examine the faulting thead/task. When the debugging session
+ * is over, this function returns (so that thread/task cleanup can continue).
+ */
+void udebug_thread_fault(void)
+{
+        udebug_stoppable_begin();
+
+        /* Wait until a debugger attends to us. */
+        mutex_lock(&THREAD->udebug.lock);
+        while (!THREAD->udebug.active)
+                condvar_wait(&THREAD->udebug.active_cv, &THREAD->udebug.lock);
+        mutex_unlock(&THREAD->udebug.lock);
+
+        /* Make sure the debugging session is over before proceeding. */
+        mutex_lock(&THREAD->udebug.lock);
+        while (THREAD->udebug.active)
+                condvar_wait(&THREAD->udebug.active_cv, &THREAD->udebug.lock);
+        mutex_unlock(&THREAD->udebug.lock);
+
+        udebug_stoppable_end();
+}
 
 /** @}

kernel/generic/src/udebug/udebug_ipc.c

@@ -41 +41 @@
 #include <proc/task.h>
 #include <proc/thread.h>
+#include <mm/as.h>
 #include <arch.h>
 #include <errno.h>
@@ -165 +166 @@
 static void udebug_receive_thread_read(call_t *call)
 {
+        uintptr_t uspace_addr;
+        size_t buf_size;
+        void *buffer;
+        size_t copied, needed;
+        int rc;
+
+        uspace_addr = IPC_GET_ARG2(call->data); /* Destination address */
+        buf_size = IPC_GET_ARG3(call->data);    /* Dest. buffer size */
+
+        /*
+         * Read thread list. Variable n will be filled with actual number
+         * of threads times thread-id size.
+         */
+        rc = udebug_thread_read(&buffer, buf_size, &copied, &needed);
+        if (rc < 0) {
+                IPC_SET_RETVAL(call->data, rc);
+                ipc_answer(&TASK->kb.box, call);
+                return;
+        }
+
+        /*
+         * Make use of call->buffer to transfer data to caller's userspace
+         */
+
+        IPC_SET_RETVAL(call->data, 0);
+        /* ARG1=dest, ARG2=size as in IPC_M_DATA_READ so that
+           same code in process_answer() can be used 
+           (no way to distinguish method in answer) */
+        IPC_SET_ARG1(call->data, uspace_addr);
+        IPC_SET_ARG2(call->data, copied);
+        IPC_SET_ARG3(call->data, needed);
+        call->buffer = buffer;
+
+        ipc_answer(&TASK->kb.box, call);
+}
+
+/** Process a NAME_READ call.
+ *
+ * Returns a string containing the name of the task.
+ *
+ * @param call  The call structure.
+ */
+static void udebug_receive_name_read(call_t *call)
+{
         unative_t uspace_addr;
         unative_t to_copy;
-        unsigned total_bytes;
-        unsigned buf_size;
-        void *buffer;
-        size_t n;
-        int rc;
+        size_t data_size;
+        size_t buf_size;
+        void *data;
 
         uspace_addr = IPC_GET_ARG2(call->data); /* Destination address */
@@ -177 +220 @@
 
         /*
-         * Read thread list. Variable n will be filled with actual number
-         * of threads times thread-id size.
-         */
-        rc = udebug_thread_read(&buffer, buf_size, &n);
-        if (rc < 0) {
-                IPC_SET_RETVAL(call->data, rc);
-                ipc_answer(&TASK->kb.box, call);
-                return;
-        }
-
-        total_bytes = n;
-
-        /* Copy MAX(buf_size, total_bytes) bytes */
-
-        if (buf_size > total_bytes)
-                to_copy = total_bytes;
+         * Read task name.
+         */
+        udebug_name_read((char **) &data, &data_size);
+
+        /* Copy MAX(buf_size, data_size) bytes */
+
+        if (buf_size > data_size)
+                to_copy = data_size;
         else
                 to_copy = buf_size;
@@ -207 +242 @@
         IPC_SET_ARG2(call->data, to_copy);
 
-        IPC_SET_ARG3(call->data, total_bytes);
-        call->buffer = buffer;
-
-        ipc_answer(&TASK->kb.box, call);
-}
+        IPC_SET_ARG3(call->data, data_size);
+        call->buffer = data;
+
+        ipc_answer(&TASK->kb.box, call);
+}
+
+/** Process an AREAS_READ call.
+ *
+ * Returns a list of address space areas in the current task, as an array
+ * of as_area_info_t structures.
+ *
+ * @param call  The call structure.
+ */
+static void udebug_receive_areas_read(call_t *call)
+{
+        unative_t uspace_addr;
+        unative_t to_copy;
+        size_t data_size;
+        size_t buf_size;
+        void *data;
+
+        uspace_addr = IPC_GET_ARG2(call->data); /* Destination address */
+        buf_size = IPC_GET_ARG3(call->data);    /* Dest. buffer size */
+
+        /*
+         * Read area list.
+         */
+        as_get_area_info(AS, (as_area_info_t **) &data, &data_size);
+
+        /* Copy MAX(buf_size, data_size) bytes */
+
+        if (buf_size > data_size)
+                to_copy = data_size;
+        else
+                to_copy = buf_size;
+
+        /*
+         * Make use of call->buffer to transfer data to caller's userspace
+         */
+
+        IPC_SET_RETVAL(call->data, 0);
+        /* ARG1=dest, ARG2=size as in IPC_M_DATA_READ so that
+           same code in process_answer() can be used 
+           (no way to distinguish method in answer) */
+        IPC_SET_ARG1(call->data, uspace_addr);
+        IPC_SET_ARG2(call->data, to_copy);
+
+        IPC_SET_ARG3(call->data, data_size);
+        call->buffer = data;
+
+        ipc_answer(&TASK->kb.box, call);
+}
+
 
 /** Process an ARGS_READ call.
@@ -250 +333 @@
         ipc_answer(&TASK->kb.box, call);
 }
+
+/** Receive a REGS_READ call.
+ *
+ * Reads the thread's register state (istate structure).
+ */
+static void udebug_receive_regs_read(call_t *call)
+{
+        thread_t *t;
+        unative_t uspace_addr;
+        unative_t to_copy;
+        void *buffer;
+        int rc;
+
+        t = (thread_t *) IPC_GET_ARG2(call->data);
+
+        rc = udebug_regs_read(t, &buffer);
+        if (rc < 0) {
+                IPC_SET_RETVAL(call->data, rc);
+                ipc_answer(&TASK->kb.box, call);
+                return;
+        }
+
+        /*
+         * Make use of call->buffer to transfer data to caller's userspace
+         */
+
+        uspace_addr = IPC_GET_ARG3(call->data);
+        to_copy = sizeof(istate_t);
+
+        IPC_SET_RETVAL(call->data, 0);
+        /* ARG1=dest, ARG2=size as in IPC_M_DATA_READ so that
+           same code in process_answer() can be used 
+           (no way to distinguish method in answer) */
+        IPC_SET_ARG1(call->data, uspace_addr);
+        IPC_SET_ARG2(call->data, to_copy);
+
+        call->buffer = buffer;
+
+        ipc_answer(&TASK->kb.box, call);
+}
+
 
 /** Process an MEM_READ call.
@@ -331 +455 @@
                 udebug_receive_thread_read(call);
                 break;
+        case UDEBUG_M_NAME_READ:
+                udebug_receive_name_read(call);
+                break;
+        case UDEBUG_M_AREAS_READ:
+                udebug_receive_areas_read(call);
+                break;
         case UDEBUG_M_ARGS_READ:
                 udebug_receive_args_read(call);
                 break;
+        case UDEBUG_M_REGS_READ:
+                udebug_receive_regs_read(call);
+                break;
         case UDEBUG_M_MEM_READ:
                 udebug_receive_mem_read(call);

kernel/generic/src/udebug/udebug_ops.c

@@ -46 +46 @@
 #include <errno.h>
 #include <print.h>
+#include <str.h>
 #include <syscall/copy.h>
 #include <ipc/ipc.h>
 #include <udebug/udebug.h>
 #include <udebug/udebug_ops.h>
+#include <memstr.h>
 
 /**
@@ -78 +80 @@
 static int _thread_op_begin(thread_t *t, bool being_go)
 {
-        task_id_t taskid;
         ipl_t ipl;
-
-        taskid = TASK->taskid;
 
         mutex_lock(&TASK->udebug.lock);
@@ -208 +207 @@
 
                 mutex_lock(&t->udebug.lock);
-                if ((t->flags & THREAD_FLAG_USPACE) != 0)
+                if ((t->flags & THREAD_FLAG_USPACE) != 0) {
                         t->udebug.active = true;
-                mutex_unlock(&t->udebug.lock);
+                        mutex_unlock(&t->udebug.lock);
+                        condvar_broadcast(&t->udebug.active_cv);
+                } else {
+                        mutex_unlock(&t->udebug.lock);
+                }
         }
 
@@ -354 +357 @@
  *
  * If the sequence is longer than @a buf_size bytes, only as much hashes
- * as can fit are copied. The number of thread hashes copied is stored
- * in @a n.
+ * as can fit are copied. The number of bytes copied is stored in @a stored.
+ * The total number of thread bytes that could have been saved had there been
+ * enough space is stored in @a needed.
  *
  * The rationale for having @a buf_size is that this function is only
@@ -363 +367 @@
  * @param buffer        The buffer for storing thread hashes.
  * @param buf_size      Buffer size in bytes.
- * @param n             The actual number of hashes copied will be stored here.
- */
-int udebug_thread_read(void **buffer, size_t buf_size, size_t *n)
+ * @param stored        The actual number of bytes copied will be stored here.
+ * @param needed        Total number of hashes that could have been saved.
+ */
+int udebug_thread_read(void **buffer, size_t buf_size, size_t *stored,
+    size_t *needed)
 {
         thread_t *t;
         link_t *cur;
         unative_t tid;
-        unsigned copied_ids;
+        size_t copied_ids;
+        size_t extra_ids;
         ipl_t ipl;
         unative_t *id_buffer;
@@ -379 +386 @@
 
         /* Allocate a buffer to hold thread IDs */
-        id_buffer = malloc(buf_size, 0);
+        id_buffer = malloc(buf_size + 1, 0);
 
         mutex_lock(&TASK->udebug.lock);
@@ -395 +402 @@
         max_ids = buf_size / sizeof(unative_t);
         copied_ids = 0;
+        extra_ids = 0;
 
         /* FIXME: make sure the thread isn't past debug shutdown... */
         for (cur = TASK->th_head.next; cur != &TASK->th_head; cur = cur->next) {
-                /* Do not write past end of buffer */
-                if (copied_ids >= max_ids) break;
-
                 t = list_get_instance(cur, thread_t, th_link);
 
@@ -408 +413 @@
 
                 /* Not interested in kernel threads. */
-                if ((flags & THREAD_FLAG_USPACE) != 0) {
+                if ((flags & THREAD_FLAG_USPACE) == 0)
+                        continue;
+
+                if (copied_ids < max_ids) {
                         /* Using thread struct pointer as identification hash */
                         tid = (unative_t) t;
                         id_buffer[copied_ids++] = tid;
+                } else {
+                        extra_ids++;
                 }
         }
@@ -421 +431 @@
 
         *buffer = id_buffer;
-        *n = copied_ids * sizeof(unative_t);
+        *stored = copied_ids * sizeof(unative_t);
+        *needed = (copied_ids + extra_ids) * sizeof(unative_t);
+
+        return 0;
+}
+
+/** Read task name.
+ *
+ * Returns task name as non-terminated string in a newly allocated buffer.
+ * Also returns the size of the data.
+ *
+ * @param data          Place to store pointer to newly allocated block.
+ * @param data_size     Place to store size of the data.
+ *
+ * @returns             EOK.
+ */
+int udebug_name_read(char **data, size_t *data_size)
+{
+        size_t name_size;
+
+        name_size = str_size(TASK->name) + 1;
+        *data = malloc(name_size, 0);
+        *data_size = name_size;
+
+        memcpy(*data, TASK->name, name_size);
 
         return 0;
@@ -436 +470 @@
  * this function will fail with an EINVAL error code.
  *
- * @param buffer        The buffer for storing thread hashes.
+ * @param t             Thread where call arguments are to be read.
+ * @param buffer        Place to store pointer to new buffer.
+ * @return              EOK on success, ENOENT if @a t is invalid, EINVAL
+ *                      if thread state is not valid for this operation.
  */
 int udebug_args_read(thread_t *t, void **buffer)
@@ -468 +505 @@
 }
 
+/** Read the register state of the thread.
+ *
+ * The contents of the thread's istate structure are copied to a newly
+ * allocated buffer and a pointer to it is written to @a buffer. The size of
+ * the buffer will be sizeof(istate_t).
+ *
+ * Currently register state cannot be read if the thread is inside a system
+ * call (as opposed to an exception). This is an implementation limit.
+ *
+ * @param t             Thread whose state is to be read.
+ * @param buffer        Place to store pointer to new buffer.
+ * @return              EOK on success, ENOENT if @a t is invalid, EINVAL
+ *                      if thread is not in valid state, EBUSY if istate
+ *                      is not available.
+ */
+int udebug_regs_read(thread_t *t, void **buffer)
+{
+        istate_t *state, *state_buf;
+        int rc;
+
+        /* Prepare a buffer to hold the data. */
+        state_buf = malloc(sizeof(istate_t), 0);
+
+        /* On success, this will lock t->udebug.lock */
+        rc = _thread_op_begin(t, false);
+        if (rc != EOK) {
+                return rc;
+        }
+
+        state = t->udebug.uspace_state;
+        if (state == NULL) {
+                _thread_op_end(t);
+                return EBUSY;
+        }
+
+        /* Copy to the allocated buffer */
+        memcpy(state_buf, state, sizeof(istate_t));
+
+        _thread_op_end(t);
+
+        *buffer = (void *) state_buf;
+        return 0;
+}
+
 /** Read the memory of the debugged task.
  *