Changeset 34e8bab in mainline for uspace/drv/uhci-hcd/hc.c

Timestamp:

2011-04-13T21:41:50Z (13 years ago)

Author:

Jan Vesely <jano.vesely@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

8d517c3, a39cfb8, d8b275d

Parents:

b77ce84 (diff), 3eeb270f (diff)
Note: this is a merge changeset, the changes displayed below correspond to the merge itself.
Use the (diff) links above to see all the changes relative to each parent.

Message:

uhci-hcd cleanup and doxygen

Fixed: usb_endpoint_manager returns EBUSY when trying to unregister active endpoint

File:

• uspace/drv/uhci-hcd/hc.c (modified) (7 diffs)

uspace/drv/uhci-hcd/hc.c

@@ -66 +66 @@
 static int hc_interrupt_emulator(void *arg);
 static int hc_debug_checker(void *arg);
-#if 0
-static bool usb_is_allowed(
-    bool low_speed, usb_transfer_type_t transfer, size_t size);
-#endif
 /*----------------------------------------------------------------------------*/
 /** Initialize UHCI hcd driver structure
@@ -89 +85 @@
         int ret;
 
-#define CHECK_RET_DEST_FUN_RETURN(ret, message...) \
+#define CHECK_RET_RETURN(ret, message...) \
         if (ret != EOK) { \
                 usb_log_error(message); \
-                if (instance->ddf_instance) \
-                        ddf_fun_destroy(instance->ddf_instance); \
                 return ret; \
         } else (void) 0
@@ -99 +93 @@
         instance->hw_interrupts = interrupts;
         instance->hw_failures = 0;
-
-        /* Setup UHCI function. */
-        instance->ddf_instance = fun;
 
         /* allow access to hc control registers */
         regs_t *io;
         ret = pio_enable(regs, reg_size, (void**)&io);
-        CHECK_RET_DEST_FUN_RETURN(ret,
+        CHECK_RET_RETURN(ret,
             "Failed(%d) to gain access to registers at %p: %s.\n",
-            ret, str_error(ret), io);
+            ret, io, str_error(ret));
         instance->registers = io;
         usb_log_debug("Device registers at %p(%u) accessible.\n",
@@ -114 +105 @@
 
         ret = hc_init_mem_structures(instance);
-        CHECK_RET_DEST_FUN_RETURN(ret,
-            "Failed to initialize UHCI memory structures.\n");
+        CHECK_RET_RETURN(ret,
+            "Failed(%d) to initialize UHCI memory structures: %s.\n",
+            ret, str_error(ret));
 
         hc_init_hw(instance);
         if (!interrupts) {
-                instance->cleaner =
+                instance->interrupt_emulator =
                     fibril_create(hc_interrupt_emulator, instance);
-                fibril_add_ready(instance->cleaner);
-        } else {
-                /* TODO: enable interrupts here */
-        }
-
-        instance->debug_checker =
-            fibril_create(hc_debug_checker, instance);
-//      fibril_add_ready(instance->debug_checker);
+                fibril_add_ready(instance->interrupt_emulator);
+        }
+        (void)hc_debug_checker;
 
         return EOK;
@@ -228 +215 @@
         /* Set all frames to point to the first queue head */
         const uint32_t queue =
-          instance->transfers_interrupt.queue_head_pa
-          | LINK_POINTER_QUEUE_HEAD_FLAG;
+            LINK_POINTER_QH(addr_to_phys(
+                instance->transfers_interrupt.queue_head));
 
         unsigned i = 0;
@@ -236 +223 @@
         }
 
-        /* Init device keeper*/
+        /* Init device keeper */
         usb_device_keeper_init(&instance->manager);
         usb_log_debug("Initialized device manager.\n");
@@ -479 +466 @@
 #undef QH
 }
-/*----------------------------------------------------------------------------*/
-/** Check transfers for USB validity
- *
- * @param[in] low_speed Transfer speed.
- * @param[in] transfer Transer type
- * @param[in] size Size of data packets
- * @return True if transaction is allowed by USB specs, false otherwise
- */
-#if 0
-bool usb_is_allowed(
-    bool low_speed, usb_transfer_type_t transfer, size_t size)
-{
-        /* see USB specification chapter 5.5-5.8 for magic numbers used here */
-        switch(transfer)
-        {
-        case USB_TRANSFER_ISOCHRONOUS:
-                return (!low_speed && size < 1024);
-        case USB_TRANSFER_INTERRUPT:
-                return size <= (low_speed ? 8 : 64);
-        case USB_TRANSFER_CONTROL: /* device specifies its own max size */
-                return (size <= (low_speed ? 8 : 64));
-        case USB_TRANSFER_BULK: /* device specifies its own max size */
-                return (!low_speed && size <= 64);
-        }
-        return false;
-}
-#endif
 /**
  * @}