Changes in uspace/app/ping/ping.c [fff7ef4:3495654] in mainline

File:

• uspace/app/ping/ping.c (modified) (10 diffs)

uspace/app/ping/ping.c

@@ -37 +37 @@
 #include <errno.h>
 #include <fibril_synch.h>
-#include <inet/dnsr.h>
+#include <inet/addr.h>
 #include <inet/inetping.h>
 #include <io/console.h>
@@ -69 +69 @@
 static void print_syntax(void)
 {
-        printf("syntax: " NAME " [-r] <host>\n");
-}
-
-static int addr_parse(const char *text, inet_addr_t *addr)
-{
-        unsigned long a[4];
-        char *cp = (char *)text;
-        int i;
-
-        for (i = 0; i < 3; i++) {
-                a[i] = strtoul(cp, &cp, 10);
-                if (*cp != '.')
-                        return EINVAL;
-                ++cp;
-        }
-
-        a[3] = strtoul(cp, &cp, 10);
-        if (*cp != '\0')
-                return EINVAL;
-
-        addr->ipv4 = 0;
-        for (i = 0; i < 4; i++) {
-                if (a[i] > 255)
-                        return EINVAL;
-                addr->ipv4 = (addr->ipv4 << 8) | a[i];
-        }
-
-        return EOK;
-}
-
-static int addr_format(inet_addr_t *addr, char **bufp)
-{
-        int rc;
-
-        rc = asprintf(bufp, "%d.%d.%d.%d", addr->ipv4 >> 24,
-            (addr->ipv4 >> 16) & 0xff, (addr->ipv4 >> 8) & 0xff,
-            addr->ipv4 & 0xff);
-
-        if (rc < 0)
-                return ENOMEM;
-
-        return EOK;
+        printf("syntax: " NAME " [-r] <addr>\n");
 }
 
@@ -126 +85 @@
         int rc;
 
-        rc = addr_format(&sdu->src, &asrc);
+        rc = inet_addr_format(&sdu->src, &asrc);
         if (rc != EOK)
                 return ENOMEM;
 
-        rc = addr_format(&sdu->dest, &adest);
+        rc = inet_addr_format(&sdu->dest, &adest);
         if (rc != EOK) {
                 free(asrc);
@@ -214 +173 @@
 int main(int argc, char *argv[])
 {
-        dnsr_hostinfo_t *hinfo = NULL;
-        char *asrc = NULL;
-        char *adest = NULL;
-        char *sdest = NULL;
         int rc;
         int argi;
@@ -225 +180 @@
                 printf(NAME ": Failed connecting to internet ping service "
                     "(%d).\n", rc);
-                goto error;
+                return 1;
         }
 
@@ -238 +193 @@
         if (argc - argi != 1) {
                 print_syntax();
-                goto error;
+                return 1;
         }
 
         /* Parse destination address */
-        rc = addr_parse(argv[argi], &dest_addr);
-        if (rc != EOK) {
-                /* Try interpreting as a host name */
-                rc = dnsr_name2host(argv[argi], &hinfo);
-                if (rc != EOK) {
-                        printf(NAME ": Error resolving host '%s'.\n", argv[argi]);
-                        goto error;
-                }
-
-                dest_addr = hinfo->addr;
+        rc = inet_addr_parse(argv[argi], &dest_addr);
+        if (rc != EOK) {
+                printf(NAME ": Invalid address format.\n");
+                print_syntax();
+                return 1;
         }
 
@@ -258 +208 @@
         if (rc != EOK) {
                 printf(NAME ": Failed determining source address.\n");
-                goto error;
-        }
-
-        rc = addr_format(&src_addr, &asrc);
-        if (rc != EOK) {
-                printf(NAME ": Out of memory.\n");
-                goto error;
-        }
-
-        rc = addr_format(&dest_addr, &adest);
-        if (rc != EOK) {
-                printf(NAME ": Out of memory.\n");
-                goto error;
-        }
-
-        if (hinfo != NULL) {
-                rc = asprintf(&sdest, "%s (%s)", hinfo->name, adest);
-                if (rc < 0) {
-                        printf(NAME ": Out of memory.\n");
-                        goto error;
-                }
-        } else {
-                sdest = adest;
-                adest = NULL;
-        }
-
-        printf("Sending ICMP echo request from %s to %s.\n",
-            asrc, sdest);
+                return 1;
+        }
 
         fid_t fid;
@@ -293 +217 @@
                 if (fid == 0) {
                         printf(NAME ": Failed creating transmit fibril.\n");
-                        goto error;
+                        return 1;
                 }
 
@@ -301 +225 @@
                 if (fid == 0) {
                         printf(NAME ": Failed creating input fibril.\n");
-                        goto error;
+                        return 1;
                 }
 
@@ -319 +243 @@
         if (rc == ETIMEOUT) {
                 printf(NAME ": Echo request timed out.\n");
-                goto error;
-        }
-
-        free(asrc);
-        free(adest);
-        free(sdest);
-        dnsr_hostinfo_destroy(hinfo);
+                return 1;
+        }
+
         return 0;
-error:
-        free(asrc);
-        free(adest);
-        free(sdest);
-        dnsr_hostinfo_destroy(hinfo);
-        return 1;
 }