Changeset 343f2b7e in mainline

Timestamp:

2010-09-04T09:06:24Z (14 years ago)

Author:

Jakub Jermar <jakub@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

76e1121f

Parents:

0c39b96

Message:

Add extra bound checks into mips32 stack tracer.

File:

• kernel/arch/mips32/src/debug/stacktrace.c (modified) (3 diffs)

kernel/arch/mips32/src/debug/stacktrace.c

@@ -96 +96 @@
 extern char ktext_end;
 
+static bool bounds_check(uintptr_t pc)
+{
+        return (pc >= (uintptr_t) &ktext_start) &&
+            (pc < (uintptr_t) &ktext_end);
+}
+
 static bool
 scan(stack_trace_context_t *ctx, uintptr_t *prev_fp, uintptr_t *prev_ra)
@@ -106 +112 @@
         do {
                 inst--;
+                if (!bounds_check((uintptr_t) inst))
+                        return false;
 #if 0
                 /*
@@ -207 +215 @@
 {
         return !((ctx->fp == 0) || ((ctx->fp % 8) != 0) ||
-            (ctx->pc % 4 != 0) || (ctx->pc < (uintptr_t) &ktext_start) ||
-            (ctx->pc >= (uintptr_t) &ktext_end));
+            (ctx->pc % 4 != 0) || !bounds_check(ctx->pc));
 }