Changes in kernel/generic/src/console/cmd.c [2f33fbc:3266412] in mainline

File:

• kernel/generic/src/console/cmd.c (modified) (20 diffs)

kernel/generic/src/console/cmd.c

@@ -45 +45 @@
 #include <console/kconsole.h>
 #include <print.h>
+#include <log.h>
 #include <panic.h>
 #include <typedefs.h>
@@ -69 +70 @@
 #include <sysinfo/sysinfo.h>
 #include <symtab.h>
+#include <synch/workqueue.h>
+#include <synch/rcu.h>
 #include <errno.h>
 
@@ -203 +206 @@
         .func = cmd_test,
         .argc = 1,
-        .argv = test_argv
+        .argv = test_argv,
+        .hints_enum = tests_hints_enum
 };
 
@@ -243 +247 @@
         .func = cmd_desc,
         .argc = 1,
-        .argv = &desc_argv
+        .argv = &desc_argv,
+        .hints_enum = cmdtab_enum
 };
 
@@ -259 +264 @@
         .func = cmd_symaddr,
         .argc = 1,
-        .argv = &symaddr_argv
+        .argv = &symaddr_argv,
+        .hints_enum = symtab_hints_enum,
 };
 
@@ -300 +306 @@
         .func = cmd_call0,
         .argc = 1,
-        .argv = &call0_argv
+        .argv = &call0_argv,
+        .hints_enum = symtab_hints_enum
 };
 
@@ -315 +322 @@
         .func = cmd_mcall0,
         .argc = 1,
-        .argv = &mcall0_argv
+        .argv = &mcall0_argv,
+        .hints_enum = symtab_hints_enum
 };
 
@@ -337 +345 @@
         .func = cmd_call1,
         .argc = 2,
-        .argv = call1_argv
+        .argv = call1_argv,
+        .hints_enum = symtab_hints_enum
 };
 
@@ -364 +373 @@
         .func = cmd_call2,
         .argc = 3,
-        .argv = call2_argv
+        .argv = call2_argv,
+        .hints_enum = symtab_hints_enum
 };
 
@@ -397 +407 @@
         .func = cmd_call3,
         .argc = 4,
-        .argv = call3_argv
+        .argv = call3_argv,
+        .hints_enum = symtab_hints_enum
 };
 
@@ -523 +534 @@
         .argc = 1,
         .argv = &zone_argv
+};
+
+/* Data and methods for the 'workq' command */
+static int cmd_workq(cmd_arg_t *argv);
+static cmd_info_t workq_info = {
+        .name = "workq",
+        .description = "Show global workq information.",
+        .func = cmd_workq,
+        .argc = 0
+};
+
+/* Data and methods for the 'workq' command */
+static int cmd_rcu(cmd_arg_t *argv);
+static cmd_info_t rcu_info = {
+        .name = "rcu",
+        .description = "Show RCU run-time statistics.",
+        .func = cmd_rcu,
+        .argc = 0
 };
 
@@ -588 +617 @@
         &physmem_info,
         &reboot_info,
+        &rcu_info,
         &sched_info,
         &set4_info,
@@ -598 +628 @@
         &uptime_info,
         &version_info,
+        &workq_info,
         &zones_info,
         &zone_info,
@@ -639 +670 @@
         for (i = 0; basic_commands[i]; i++) {
                 if (!cmd_register(basic_commands[i])) {
-                        printf("Cannot register command %s\n",
+                        log(LF_OTHER, LVL_ERROR,
+                            "Cannot register command %s",
                             basic_commands[i]->name);
                 }
@@ -656 +688 @@
         
         size_t len = 0;
-        list_foreach(cmd_list, cur) {
-                cmd_info_t *hlp;
-                hlp = list_get_instance(cur, cmd_info_t, link);
-                
+        list_foreach(cmd_list, link, cmd_info_t, hlp) {
                 spinlock_lock(&hlp->lock);
                 if (str_length(hlp->name) > len)
@@ -668 +697 @@
         unsigned int _len = (unsigned int) len;
         if ((_len != len) || (((int) _len) < 0)) {
-                printf("Command length overflow\n");
+                log(LF_OTHER, LVL_ERROR, "Command length overflow");
                 return 1;
         }
         
-        list_foreach(cmd_list, cur) {
-                cmd_info_t *hlp;
-                hlp = list_get_instance(cur, cmd_info_t, link);
-                
+        list_foreach(cmd_list, link, cmd_info_t, hlp) {
                 spinlock_lock(&hlp->lock);
                 printf("%-*s %s\n", _len, hlp->name, hlp->description);
@@ -912 +938 @@
         spinlock_lock(&cmd_lock);
         
-        list_foreach(cmd_list, cur) {
-                cmd_info_t *hlp;
-                
-                hlp = list_get_instance(cur, cmd_info_t, link);
+        list_foreach(cmd_list, link, cmd_info_t, hlp) {
                 spinlock_lock(&hlp->lock);
                 
@@ -1156 +1179 @@
 int cmd_set4(cmd_arg_t *argv)
 {
-        uintptr_t addr;
+        uintptr_t addr = 0; // Prevent -Werror=maybe-uninitialized
         uint32_t arg1 = argv[1].intval;
         bool pointer = false;
@@ -1280 +1303 @@
 }
 
+/** Prints information about the global work queue.
+ *
+ * @param argv Ignores
+ *
+ * @return Always 1
+ */
+int cmd_workq(cmd_arg_t *argv)
+{
+        workq_global_print_info();
+        return 1;
+}
+
+/** Prints RCU statistics.
+ *
+ * @param argv Ignores
+ *
+ * @return Always 1
+ */
+int cmd_rcu(cmd_arg_t *argv)
+{
+        rcu_print_stat();
+        return 1;
+}
+
 /** Command for listing memory zones
  *
@@ -1364 +1411 @@
         printf("The kernel will now relinquish the console.\n");
         release_console();
-        
-        event_notify_0(EVENT_KCONSOLE, false);
         indev_pop_character(stdin);