Changeset 3083c74 in mainline

Timestamp:

2018-11-27T16:49:07Z (6 years ago)

Author:

Jakub Jermar <jakub@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

b10e9367

Parents:

f89204ee

git-author:

Jakub Jermar <jakub@…> (2018-11-25 17:40:59)

git-committer:

Jakub Jermar <jakub@…> (2018-11-27 16:49:07)

Message:

Fix devman device reference counting

After commit 498ced1, create_dev_node() returns a dev pointer with an
implicit reference. Adding an extra reference for creation thus adds a
reference that will never be dropped and the device object will be
leaked.

This commit removes the extra reference.

Location:

uspace/srv/devman

Files:

• devtree.c (modified) (1 diff)
• fun.c (modified) (1 diff)

uspace/srv/devman/devtree.c

@@ -165 +165 @@
         }
 
-        dev_add_ref(dev);
         insert_dev_node(tree, dev, fun);
 

uspace/srv/devman/fun.c

@@ -317 +317 @@
 
                 insert_dev_node(&device_tree, dev, fun);
-                dev_add_ref(dev);
         }