Changes in uspace/drv/time/cmos-rtc/cmos-rtc.c [0a586f4c:289fa65] in mainline

File:

• uspace/drv/time/cmos-rtc/cmos-rtc.c (modified) (4 diffs)

uspace/drv/time/cmos-rtc/cmos-rtc.c

@@ -99 +99 @@
 static void rtc_register_write(rtc_t *rtc, int reg, int data);
 static time_t uptime_get(void);
-static bool is_battery_ok(rtc_t *rtc);
 
 static ddf_dev_ops_t rtc_dev_ops;
@@ -335 +334 @@
         }
 
-        /* Check if the RTC battery is OK */
-        if (!is_battery_ok(rtc)) {
-                fibril_mutex_unlock(&rtc->mutex);
-                return EIO;
-        }
-
         /* now read the registers */
         do {
@@ -443 +436 @@
 
         fibril_mutex_lock(&rtc->mutex);
-
-        if (!is_battery_ok(rtc)) {
-                fibril_mutex_unlock(&rtc->mutex);
-                return EIO;
-        }
 
         /* boottime must be recomputed */
@@ -528 +516 @@
 {
         rtc_t *rtc = fun_rtc(fun);
-
-        fibril_mutex_lock(&rtc->mutex);
-        const bool batt_ok = is_battery_ok(rtc);
-        fibril_mutex_unlock(&rtc->mutex);
+        const bool batt_ok = rtc_register_read(rtc, RTC_STATUS_D) &
+            RTC_D_BATTERY_OK;
 
         *status = batt_ok ? BATTERY_OK : BATTERY_LOW;
 
         return EOK;
-}
-
-/** Check if the battery is working properly or not.
- *  The caller already holds the rtc->mutex lock.
- *
- *  @param rtc   The RTC instance.
- *
- *  @return      true if the battery is ok, false otherwise.
- */
-static bool
-is_battery_ok(rtc_t *rtc)
-{
-        return rtc_register_read(rtc, RTC_STATUS_D) & RTC_D_BATTERY_OK;
 }