Changes in uspace/lib/usb/src/ddfiface.c [79ae36dd:27ed734c] in mainline

File:

• uspace/lib/usb/src/ddfiface.c (modified) (6 diffs)

uspace/lib/usb/src/ddfiface.c

@@ -39 +39 @@
 #include <usb/hc.h>
 #include <usb/debug.h>
+#include <usb/dev/hub.h>
 #include <errno.h>
 #include <assert.h>
 
 /** DDF interface for USB device, implementation for typical hub. */
-usb_iface_t  usb_iface_hub_impl = {
-        .get_hc_handle = usb_iface_get_hc_handle_hub_impl,
-        .get_address = usb_iface_get_address_hub_impl
+usb_iface_t usb_iface_hub_impl = {
+        .get_hc_handle = usb_iface_get_hc_handle_device_impl,
+        .get_my_address = usb_iface_get_my_address_forward_impl,
 };
 
 /** DDF interface for USB device, implementation for child of a typical hub. */
-usb_iface_t  usb_iface_hub_child_impl = {
-        .get_hc_handle = usb_iface_get_hc_handle_hub_child_impl,
-        .get_address = usb_iface_get_address_hub_child_impl
+usb_iface_t usb_iface_hub_child_impl = {
+        .get_hc_handle = usb_iface_get_hc_handle_device_impl,
+        .get_my_address = usb_iface_get_my_address_from_device_data,
 };
 
@@ -61 +62 @@
  * @return Error code.
  */
-int usb_iface_get_hc_handle_hub_impl(ddf_fun_t *fun, devman_handle_t *handle)
+int usb_iface_get_hc_handle_device_impl(ddf_fun_t *fun, devman_handle_t *handle)
 {
         assert(fun);
         return usb_hc_find(fun->handle, handle);
-}
-
-/** Get host controller handle, interface implementation for child of
- * a hub driver.
- *
- * @param[in] fun Device function the operation is running on.
- * @param[out] handle Storage for the host controller handle.
- * @return Error code.
- */
-int usb_iface_get_hc_handle_hub_child_impl(ddf_fun_t *fun,
-    devman_handle_t *handle)
-{
-        assert(fun != NULL);
-        
-        async_sess_t *parent_sess =
-            devman_parent_device_connect(EXCHANGE_SERIALIZE, fun->handle,
-            IPC_FLAG_BLOCKING);
-        if (!parent_sess)
-                return ENOMEM;
-        
-        async_exch_t *exch = async_exchange_begin(parent_sess);
-        
-        sysarg_t hc_handle;
-        int rc = async_req_1_1(exch, DEV_IFACE_ID(USB_DEV_IFACE),
-            IPC_M_USB_GET_HOST_CONTROLLER_HANDLE, &hc_handle);
-        
-        async_exchange_end(exch);
-        async_hangup(parent_sess);
-        
-        if (rc != EOK)
-                return rc;
-        
-        *handle = hc_handle;
-        return EOK;
 }
 
@@ -125 +92 @@
  * @return Error code.
  */
-int usb_iface_get_address_hub_impl(ddf_fun_t *fun, devman_handle_t handle,
+int usb_iface_get_my_address_forward_impl(ddf_fun_t *fun,
     usb_address_t *address)
 {
         assert(fun);
-        
+
         async_sess_t *parent_sess =
             devman_parent_device_connect(EXCHANGE_SERIALIZE, fun->handle,
@@ -135 +102 @@
         if (!parent_sess)
                 return ENOMEM;
-        
+
         async_exch_t *exch = async_exchange_begin(parent_sess);
-        
+
         sysarg_t addr;
-        int rc = async_req_2_1(exch, DEV_IFACE_ID(USB_DEV_IFACE),
-            IPC_M_USB_GET_ADDRESS, handle, &addr);
-        
+        int rc = async_req_1_1(exch, DEV_IFACE_ID(USB_DEV_IFACE),
+            IPC_M_USB_GET_MY_ADDRESS, &addr);
+
         async_exchange_end(exch);
         async_hangup(parent_sess);
-        
+
         if (rc != EOK)
                 return rc;
-        
+
         if (address != NULL)
                 *address = (usb_address_t) addr;
-        
+
         return EOK;
 }
@@ -157 +124 @@
  * a hub driver.
  *
+ * This implementation eccepts 0 as valid handle and replaces it with fun's
+ * handle.
+ *
  * @param[in] fun Device function the operation is running on.
  * @param[in] handle Devman handle of USB device we want address of.
@@ -162 +132 @@
  * @return Error code.
  */
-int usb_iface_get_address_hub_child_impl(ddf_fun_t *fun,
-    devman_handle_t handle, usb_address_t *address)
+int usb_iface_get_my_address_from_device_data(ddf_fun_t *fun,
+    usb_address_t *address)
 {
-        if (handle == 0) {
-                handle = fun->handle;
-        }
-        return usb_iface_get_address_hub_impl(fun, handle, address);
+        assert(fun);
+        assert(fun->driver_data);
+        usb_hub_attached_device_t *device = fun->driver_data;
+        assert(device->fun == fun);
+        if (address)
+                *address = device->address;
+        return EOK;
 }