Changeset 273c976 in mainline

Timestamp:

2013-07-15T20:36:54Z (11 years ago)

Author:

Jan Vesely <jano.vesely@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

f3386d7

Parents:

59a72f8

Message:

arm32, bbxm: Follow the manual in ISR steps order.

Fixes ghost interrupt issue (firing two interrupts instead of one).
Maurizio pointed out the correct fix on irc.

File:

• kernel/arch/arm32/src/mach/beagleboardxm/beagleboardxm.c (modified) (3 diffs)

kernel/arch/arm32/src/mach/beagleboardxm/beagleboardxm.c

@@ -85 +85 @@
 static void bb_timer_irq_handler(irq_t *irq)
 {
-        // FIXME Ignore the weird ghost interrupt
-        if (!amdm37x_gpt_irq_ack(&beagleboard.timer))
-                return;
+        amdm37x_gpt_irq_ack(&beagleboard.timer);
 
         /*
@@ -150 +148 @@
 {
         const unsigned inum = amdm37x_irc_inum_get(beagleboard.irc_addr);
-        amdm37x_irc_irq_ack(beagleboard.irc_addr);
 
         irq_t *irq = irq_dispatch_and_lock(inum);
@@ -162 +159 @@
                     CPU->id, inum);
         }
+        /** amdm37x manual ch. 12.5.2 (p. 2428) places irc ack at the end
+         * of ISR. DO this to avoid strange behavior. */
+        amdm37x_irc_irq_ack(beagleboard.irc_addr);
 }