Changeset 1526c174 in mainline

Timestamp:

2011-10-14T23:34:51Z (13 years ago)

Author:

Jan Vesely <jano.vesely@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

2a5b62b

Parents:

bd444e5

Message:

libusbdev: Unregister only endpoints that are present.

Not present endpoints don't need it and do not have to be fully initialized.
Fixes crash on usbhid unplug.

Location:

uspace/lib/usbdev/src

Files:

• devdrv.c (modified) (1 diff)
• pipesinit.c (modified) (1 diff)

uspace/lib/usbdev/src/devdrv.c

@@ -469 +469 @@
         size_t i;
         for (i = 0; i < pipes_count; i++) {
-                usb_pipe_unregister(pipes[i].pipe, &hc_conn);
+                usb_log_debug2("Unregistering pipe %zu (%spresent).\n",
+                    i, pipes[i].present ? "" : "not ");
+                if (pipes[i].present)
+                        usb_pipe_unregister(pipes[i].pipe, &hc_conn);
                 free(pipes[i].pipe);
         }

uspace/lib/usbdev/src/pipesinit.c

@@ -514 +514 @@
 {
         assert(pipe);
+        assert(pipe->wire);
         assert(hc_connection);