Changes in / [aa85487:137691a] in mainline

Files:

• boot/Makefile.common (modified) (3 diffs)
• uspace/lib/libpci/Makefile.build (deleted)
• uspace/lib/libpci/Makefile.common (deleted)
• uspace/srv/bd/part/mbr_part/Makefile.build (deleted)
• uspace/srv/bd/part/mbr_part/Makefile.common (deleted)
• uspace/srv/hid/char_mouse/Makefile.build (deleted)
• uspace/srv/hid/char_mouse/Makefile.common (deleted)
• uspace/srv/hw/bus/pci/Makefile.build (deleted)
• uspace/srv/hw/bus/pci/Makefile.common (deleted)
• uspace/srv/hw/char/i8042/Makefile.build (deleted)
• uspace/srv/hw/char/i8042/Makefile.common (deleted)
• uspace/srv/hw/cir/fhc/Makefile.build (deleted)
• uspace/srv/hw/cir/fhc/Makefile.common (deleted)
• uspace/srv/hw/cir/obio/Makefile.build (deleted)
• uspace/srv/hw/cir/obio/Makefile.common (deleted)
• uspace/srv/net/Makefile (modified) (2 diffs)
• uspace/srv/net/include/socket.h (modified) (1 diff)
• uspace/srv/net/module.c (modified) (1 diff)
• uspace/srv/net/tl/icmp/icmp.c (modified) (6 diffs)
• uspace/srv/net/tl/tcp/tcp.c (modified) (4 diffs)
• uspace/srv/net/tl/udp/udp.c (modified) (6 diffs)

boot/Makefile.common

@@ -91 +91 @@
         $(USPACEDIR)/srv/net/net/net \
         $(USPACEDIR)/srv/net/netif/lo/lo \
+        $(USPACEDIR)/srv/net/netif/dp8390/dp8390 \
         $(USPACEDIR)/srv/net/nil/eth/eth \
         $(USPACEDIR)/srv/net/nil/nildummy/nildummy \
@@ -104 +105 @@
 NET_CFG = \
         $(USPACEDIR)/srv/net/cfg/$(NETWORKING)/general \
-        $(USPACEDIR)/srv/net/cfg/$(NETWORKING)/lo
-
-ifeq ($(CONFIG_NETIF_DP8390),y)
-        NET_SRVS        +=      $(USPACEDIR)/srv/net/netif/dp8390/dp8390
-
-        NET_CFG +=      $(USPACEDIR)/srv/net/cfg/$(NETWORKING)/ne2k
+        $(USPACEDIR)/srv/net/cfg/$(NETWORKING)/lo \
+        $(USPACEDIR)/srv/net/cfg/$(NETWORKING)/ne2k
 endif
 
@@ -133 +130 @@
 endif
 endif
-endif
+

uspace/srv/net/Makefile

@@ -31 +31 @@
 DIRS = \
         netif/lo \
+        netif/dp8390 \
         nil/eth \
         nil/nildummy \
@@ -47 +48 @@
                 tl/udp \
                 tl/tcp \
-
-ifeq ($(CONFIG_NETIF_DP8390),y)
-        DIRS += netif/dp8390
-endif
 
 DIRS_ALL = $(DIRS) $(DIRS_MODULAR)

uspace/srv/net/include/socket.h

@@ -61 +61 @@
  *  @returns EPROTONOSUPPORT if the protocol is not supported.
  *  @returns ENOMEM if there is not enough memory left.
- *  @returns ELIMIT if there was not a free socket identifier found this time.
  *  @returns Other error codes as defined for the NET_SOCKET message.
  *  @returns Other error codes as defined for the bind_service_timeout() function.

uspace/srv/net/module.c

@@ -110 +110 @@
                 res = module_message( callid, & call, & answer, & answer_count );
 
-                if(( IPC_GET_METHOD( call ) == IPC_M_PHONE_HUNGUP ) || ( res == EHANGUP )){
-                        return;
-                }
+                if( IPC_GET_METHOD( call ) == IPC_M_PHONE_HUNGUP ) return;
 
                 answer_call( callid, res, & answer, answer_count );

uspace/srv/net/tl/icmp/icmp.c

@@ -658 +658 @@
         ipc_callid_t                    data_callid;
         icmp_echo_ref                   echo_data;
-        int                                             res;
 
         /*
@@ -664 +663 @@
          *  - Answer the first NET_ICMP_INIT call.
          */
-        res = EOK;
-        answer_count = 0;
+        ipc_answer_0( callid, EOK );
 
 //      fibril_rwlock_initialize( & lock );
@@ -671 +669 @@
         echo_data = ( icmp_echo_ref ) malloc( sizeof( * echo_data ));
         if( ! echo_data ) return ENOMEM;
-
         // assign a new identifier
         fibril_rwlock_write_lock( & icmp_globals.lock );
-        res = icmp_bind_free_id( echo_data );
+        ERROR_CODE = icmp_bind_free_id( echo_data );
         fibril_rwlock_write_unlock( & icmp_globals.lock );
-        if( res < 0 ){
+        if( ERROR_CODE < 0 ){
                 free( echo_data );
-                return res;
+                return ERROR_CODE;
         }
 
         while( keep_on_going ){
-
-                // answer the call
-                answer_call( callid, res, & answer, answer_count );
-
-                // refresh data
                 refresh_answer( & answer, & answer_count );
 
-                // get the next call
                 callid = async_get_call( & call );
 
-                // process the call
                 switch( IPC_GET_METHOD( call )){
                         case IPC_M_PHONE_HUNGUP:
                                 keep_on_going = false;
-                                res = EHANGUP;
+                                ERROR_CODE = EOK;
                                 break;
                         case NET_ICMP_ECHO:
 //                              fibril_rwlock_write_lock( & lock );
                                 if( ! async_data_write_receive( & data_callid, & length )){
-                                        res = EINVAL;
+                                        ERROR_CODE = EINVAL;
                                 }else{
                                         addr = malloc( length );
                                         if( ! addr ){
-                                                res = ENOMEM;
+                                                ERROR_CODE = ENOMEM;
                                         }else{
                                                 if( ! ERROR_OCCURRED( async_data_write_finalize( data_callid, addr, length ))){
                                                         fibril_rwlock_write_lock( & icmp_globals.lock );
-                                                        res = icmp_echo( echo_data->identifier, echo_data->sequence_number, ICMP_GET_SIZE( call ), ICMP_GET_TIMEOUT( call ), ICMP_GET_TTL( call ), ICMP_GET_TOS( call ), ICMP_GET_DONT_FRAGMENT( call ), addr, ( socklen_t ) length );
+                                                        ERROR_CODE = icmp_echo( echo_data->identifier, echo_data->sequence_number, ICMP_GET_SIZE( call ), ICMP_GET_TIMEOUT( call ), ICMP_GET_TTL( call ), ICMP_GET_TOS( call ), ICMP_GET_DONT_FRAGMENT( call ), addr, ( socklen_t ) length );
                                                         fibril_rwlock_write_unlock( & icmp_globals.lock );
                                                         free( addr );
@@ -717 +707 @@
                                                                 echo_data->sequence_number = 0;
                                                         }
-                                                }else{
-                                                        res = ERROR_CODE;
                                                 }
                                         }
@@ -725 +713 @@
                                 break;
                         default:
-                                res = icmp_process_message( & call );
+                                ERROR_CODE = icmp_process_message( & call );
                 }
+
+                answer_call( callid, ERROR_CODE, & answer, answer_count );
         }
 
@@ -733 +723 @@
         icmp_echo_data_exclude( & icmp_globals.echo_data, echo_data->identifier );
         fibril_rwlock_write_unlock( & icmp_globals.lock );
-        return res;
+        return EOK;
 }
 

uspace/srv/net/tl/tcp/tcp.c

@@ -1070 +1070 @@
          *  - Answer the first IPC_M_CONNECT_ME_TO call.
          */
-        res = EOK;
-        answer_count = 0;
+        ipc_answer_0( callid, EOK );
 
         socket_cores_initialize( & local_sockets );
@@ -1077 +1076 @@
 
         while( keep_on_going ){
-
-                // answer the call
-                answer_call( callid, res, & answer, answer_count );
-
                 // refresh data
                 refresh_answer( & answer, & answer_count );
 
-                // get the next call
                 callid = async_get_call( & call );
-
-                // process the call
+//              printf( "message %d\n", IPC_GET_METHOD( * call ));
+
                 switch( IPC_GET_METHOD( call )){
                         case IPC_M_PHONE_HUNGUP:
                                 keep_on_going = false;
-                                res = EHANGUP;
+                                res = EOK;
                                 break;
                         case NET_SOCKET:
@@ -1237 +1231 @@
                                 break;
                 }
+
+//              printf( "res = %d\n", res );
+
+                answer_call( callid, res, & answer, answer_count );
         }
 
@@ -1275 +1273 @@
                                         // TODO release as connection lost
                                         //tcp_refresh_socket_data( socket_data );
-                                }else{
-                                        // retransmit
-                                        tcp_retransmit_packet( socket, socket_data, timeout->sequence_number );
-                                }
+                                }
+                                // retransmit
+                                // TODO enable retransmit
+                                //tcp_retransmit_packet( socket, socket_data, timeout->sequence_number );
                                 fibril_rwlock_write_unlock( socket_data->local_lock );
                         }else{

uspace/srv/net/tl/udp/udp.c

@@ -390 +390 @@
         fibril_rwlock_write_unlock( & udp_globals.lock );
         async_msg_5( socket->phone, NET_SOCKET_RECEIVED, ( ipcarg_t ) socket->socket_id, packet_dimension->content, 0, 0, ( ipcarg_t ) fragments );
-        return EOK;
+/*      fibril_rwlock_write_unlock( & udp_globals.lock );
+        async_msg_5( socket->phone, NET_SOCKET_RECEIVED, ( ipcarg_t ) socket->socket_id, 0, 0, 0, ( ipcarg_t ) fragments );
+*/      return EOK;
 }
 
@@ -427 +429 @@
          *  - Answer the first IPC_M_CONNECT_TO_ME call.
          */
-        res = EOK;
-        answer_count = 0;
+        ipc_answer_0( callid, EOK );
 
         // The client connection is only in one fibril and therefore no additional locks are needed.
@@ -436 +437 @@
 
         while( keep_on_going ){
-
-                // answer the call
-                answer_call( callid, res, & answer, answer_count );
-
                 // refresh data
                 refresh_answer( & answer, & answer_count );
 
-                // get the next call
                 callid = async_get_call( & call );
-
-                // process the call
+//              printf( "message %d\n", IPC_GET_METHOD( * call ));
+
                 switch( IPC_GET_METHOD( call )){
                         case IPC_M_PHONE_HUNGUP:
                                 keep_on_going = false;
-                                res = EHANGUP;
+                                res = EOK;
                                 break;
                         case NET_SOCKET:
@@ -518 +514 @@
                                 break;
                 }
+
+//              printf( "res = %d\n", res );
+
+                answer_call( callid, res, & answer, answer_count );
         }
 
@@ -523 +523 @@
         socket_cores_release( udp_globals.net_phone, & local_sockets, & udp_globals.sockets, NULL );
 
-        return res;
+        return EOK;
 }
 
@@ -618 +618 @@
         header->checksum = 0;
         if( udp_globals.checksum_computing ){
-                // update the pseudo header
-                if( ERROR_OCCURRED( ip_client_set_pseudo_header_data_length( ip_header, headerlen, total_length + UDP_HEADER_SIZE ))){
+//              if( ERROR_OCCURRED( ip_get_route_req( udp_globals.ip_phone, IPPROTO_UDP, addr, addrlen, & device_id, & ip_header, & headerlen ))){
+//                      return udp_release_and_return( packet, ERROR_CODE );
+//              }
+                if( ERROR_OCCURRED( ip_client_set_pseudo_header_data_length( ip_header, headerlen, total_length + UDP_HEADER_SIZE))){
                         free( ip_header );
                         return udp_release_and_return( packet, ERROR_CODE );
                 }
-                // finish the checksum computation
                 checksum = compute_checksum( checksum, ip_header, headerlen );
                 checksum = compute_checksum( checksum, ( uint8_t * ) header, sizeof( * header ));