Changeset 10ef47ba in mainline

Timestamp:

2014-05-20T14:24:16Z (11 years ago)

Author:

Martin Decky <martin@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

69d25e2

Parents:

bf9cb2f

Message:

avoid double free of prefix
(detected by Coverity, CID 10457)

File:

• uspace/app/bdsh/compl.c (modified) (2 diffs)

uspace/app/bdsh/compl.c

@@ -209 +209 @@
                 *cstart += rpath_sep + 1 - prefix;
                 free(prefix);
+                prefix = NULL;
 
                 cs->path_list = malloc(sizeof(char *) * 2);
@@ -252 +253 @@
         }
 
-        if (cs != NULL && cs->prefix != NULL)
+        if ((cs != NULL) && (cs->prefix != NULL))
                 free(cs->prefix);
+        
         if (dirname != NULL)
                 free(dirname);
+        
         if (prefix != NULL)
                 free(prefix);
+        
         if (stext != NULL)
                 free(stext);
+        
         if (cs != NULL)
                 free(cs);
+        
         if (tokens != NULL)
                 free(tokens);