Changeset 0f4f1b2 in mainline for kernel/generic/src/main/kinit.c

Timestamp:

2024-01-15T17:10:27Z (16 months ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

master

Children:

e82879c

Parents:

a064d4f

git-author:

Jiří Zárevúcky <zarevucky.jiri@…> (2024-01-15 16:37:22)

git-committer:

Jiří Zárevúcky <zarevucky.jiri@…> (2024-01-15 17:10:27)

Message:

Add (and use) functions thread_start() and thread_detach()

Mostly cosmetic, with thread_start() replacing calls to thread_ready(),
but not consuming the passed reference, and thread_detach() being
synonym for thread_put(). Makes the code's function more obvious.

Also modify some threaded tests to use thread_join() for waiting,
instead of counting threads with atomics or semaphores.

File:

• kernel/generic/src/main/kinit.c (modified) (4 diffs)

kernel/generic/src/main/kinit.c

@@ -122 +122 @@
 
                 thread_wire(thread, &cpus[0]);
-                thread_ready(thread_ref(thread));
+                thread_start(thread);
                 thread_join(thread);
 
@@ -135 +135 @@
                         if (thread != NULL) {
                                 thread_wire(thread, &cpus[i]);
-                                thread_ready(thread);
+                                thread_start(thread);
+                                thread_detach(thread);
                         } else
                                 log(LF_OTHER, LVL_ERROR,
@@ -151 +152 @@
         thread = thread_create(kload, NULL, TASK, THREAD_FLAG_NONE,
             "kload");
-        if (thread != NULL)
-                thread_ready(thread);
-        else
+        if (thread != NULL) {
+                thread_start(thread);
+                thread_detach(thread);
+        } else {
                 log(LF_OTHER, LVL_ERROR, "Unable to create kload thread");
+        }
 
 #ifdef CONFIG_KCONSOLE
@@ -163 +166 @@
                 thread = thread_create(kconsole_thread, NULL, TASK,
                     THREAD_FLAG_NONE, "kconsole");
-                if (thread != NULL)
-                        thread_ready(thread);
-                else
+                if (thread != NULL) {
+                        thread_start(thread);
+                        thread_detach(thread);
+                } else {
                         log(LF_OTHER, LVL_ERROR,
                             "Unable to create kconsole thread");
+                }
         }
 #endif /* CONFIG_KCONSOLE */