Changeset 09024119 in mainline

Timestamp:

2015-06-04T14:00:24Z (10 years ago)

Author:

Martin Decky <martin@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

315b7e3

Parents:

022d72ff

Message:

fix possible NULL pointer derefence in answer_need_old() before a NULL check in sys_ipc_forward_common()
(reported by Coverity as CID 10450)

File:

• kernel/generic/src/ipc/sysipc.c (modified) (2 diffs)

kernel/generic/src/ipc/sysipc.c

@@ -388 +388 @@
 {
         call_t *call = get_call(callid);
-        phone_t *phone;
-        bool need_old = answer_need_old(call);
-        bool after_forward = false;
-        ipc_data_t old;
-        int rc;
-
         if (!call)
                 return ENOENT;
-
+        
+        ipc_data_t old;
+        bool need_old = answer_need_old(call);
         if (need_old)
                 old = call->data;
+        
+        bool after_forward = false;
+        int rc;
+        phone_t *phone;
         
         if (phone_get(phoneid, &phone) != EOK) {
@@ -409 +409 @@
                 goto error;
         }
-
+        
         call->flags |= IPC_CALL_FORWARDED;