Changeset 05b59393 in mainline for uspace/app

Timestamp:

2017-10-04T18:02:14Z (8 years ago)

Author:

jzr <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

c9e88da

Parents:

0b2d369

Message:

Fix a couple of benign clang warnings.
No change in semantics.

Location:

uspace/app

Files:

• bdsh/cmds/builtin_cmds.c (modified) (1 diff)
• bdsh/cmds/mod_cmds.c (modified) (1 diff)
• fontviewer/fontviewer.c (modified) (1 diff)
• sbi/src/builtin/bi_task.c (modified) (1 diff)
• sbi/src/run_expr.c (modified) (1 diff)

uspace/app/bdsh/cmds/builtin_cmds.c

@@ -79 +79 @@
                 return (char *)NULL;
 
-        for(i=0; builtin_aliases[i] != NULL; i++) {
+        for(i=0; builtin_aliases[i] != NULL; i+=2) {
                 if (!str_cmp(builtin_aliases[i], command))
-                        return (char *)builtin_aliases[++i];
-                i++;
+                        return (char *)builtin_aliases[i+1];
         }
 

uspace/app/bdsh/cmds/mod_cmds.c

@@ -96 +96 @@
                 return (char *)NULL;
 
-        for(i=0; mod_aliases[i] != NULL; i++) {
+        for(i=0; mod_aliases[i] != NULL; i+=2) {
                 if (!str_cmp(mod_aliases[i], command))
-                        return (char *)mod_aliases[++i];
-                i++;
+                        return (char *)mod_aliases[i+1];
         }
 

uspace/app/fontviewer/fontviewer.c

@@ -78 +78 @@
                                 points += increment;
                 
-                        if ((event->key == KC_DOWN)) {
+                        if (event->key == KC_DOWN) {
                                 if (points <= increment) {
                                         points = 1;

uspace/app/sbi/src/builtin/bi_task.c

@@ -114 +114 @@
         }
 
-        cmd[dim] = '\0';
+        cmd[dim] = NULL;
 
         if (os_exec((char * const *)cmd) != EOK) {

uspace/app/sbi/src/run_expr.c

@@ -2886 +2886 @@
                                 /* Is it static/nonstatic? */
                                 var_sn = stree_symbol_has_attr(
-                                    var_to_symbol(var), sac_static);
+                                    var_to_symbol(var), sac_static) ? sn_static : sn_nonstatic;
                                 if (var_sn == sn) {
                                         /* Compute field type. XXX Memoize. */