Changeset 0460377 in mainline

Timestamp:

2025-04-25T15:43:15Z (12 days ago)

Author:

GitHub <noreply@…>

Branches:

master

Children:

4b9213d

Parents:

a22c62f

git-author:

Miroslav Cimerman <70661600+mcimerman@…> (2025-04-25 15:43:15)

git-committer:

GitHub <noreply@…> (2025-04-25 15:43:15)

Message:

uspace/app/blkdump: fix argv null deref (#251)

File:

• uspace/app/blkdump/blkdump.c (modified) (3 diffs)

uspace/app/blkdump/blkdump.c

@@ -95 +95 @@
         }
 
-        if (str_cmp(*argv, "--offset") == 0) {
+        if (*argv && str_cmp(*argv, "--offset") == 0) {
                 --argc;
                 ++argv;
@@ -115 +115 @@
         }
 
-        if (str_cmp(*argv, "--count") == 0) {
+        if (*argv && str_cmp(*argv, "--count") == 0) {
                 --argc;
                 ++argv;
@@ -136 +136 @@
 
 devname:
+        if (*argv == NULL) {
+                printf(NAME ": Error, argument missing (device_name).\n");
+                syntax_print();
+                return 1;
+        }
+
         if (argc != 1) {
                 printf(NAME ": Error, unexpected argument.\n");