Changes between Version 26 and Version 27 of HowToContribute
- Timestamp:
- 2017-11-21T22:37:17Z (6 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
HowToContribute
v26 v27 44 44 == Integrating your changes == 45 45 46 When you have tested your changes carefully and are confident enough that there are no bugs, you can ask one of us to merge your changes to our official repository. For that, you need to do one of two things. Either create a PR at GitHub or publish your branch in a publicly accessible location (e.g.GitHub) so that we can merge from there. Note that publishing your branch is a good idea anyway because others can see your progress and your changes are backed up.46 When you have tested your changes carefully and are confident enough that there are no bugs, you can ask one of us to merge your changes to our official repository. For that, you need to do one of two things. Either create a PR at !GitHub or publish your branch in a publicly accessible location (e.g. !GitHub) so that we can merge from there. Note that publishing your branch is a good idea anyway because others can see your progress and your changes are backed up. 47 47 48 48 Eventually, if your changes look good to us, we will merge them and you will become part of the history. However, this final step might require some patience. We never merge any code only because we want the functionality. The overall design, the quality and the readability of the code has the same importance for us as the functionality. Properly and thoroughly reviewing the code takes time and time is something nobody has in abundance.
