Opened 14 months ago

Closed 3 days ago

#859 closed defect (fixed)

Build with Detailed kernel logging enabled fails

Reported by: Jiri Svoboda Owned by: Jiří Zárevúcky
Priority: major Milestone: 0.14.2
Component: helenos/unspecified Version: mainline
Keywords: Cc:
Blocker for: Depends on:
See also:

Description

When I try to build the OS with Detailed kernel logging build option enabled, the build fails with:

In file included from ../kernel/generic/src/main/main.c:50:
../kernel/generic/src/main/main.c: In function 'main_bsp_separated_stack':
../kernel/generic/src/main/main.c:198:21: error: 'config_t' {aka 'struct <anonymous>'} has no member named 'stack_base'
      (void *) config.stack_base, config.stack_size);
                     ^
../kernel/generic/include/debug.h:57:9: note: in definition of macro 'LOG'
       ##__VA_ARGS__); \
         ^~~~~~~~~~~
../kernel/generic/src/main/main.c:198:40: error: 'config_t' {aka 'struct <anonymous>'} has no member named 'stack_size'
      (void *) config.stack_base, config.stack_size);
                                        ^
../kernel/generic/include/debug.h:57:9: note: in definition of macro 'LOG'
       ##__VA_ARGS__); \
         ^~~~~~~~~~~
[10/1716] Compiling C object kernel/li...mentables.a.p/generic_src_mm_frame.c.o
ninja: build stopped: subcommand failed.

Presumably this problem was introduced with this commit:

commit 65f3117b0c526538a5c5e972042a0bf4f1a325e1
Author: Jiří Zárevúcky <zarevucky.jiri@gmail.com>
Date:   Tue Feb 14 14:38:14 2023 +0100

    Make bootstrap stack statically, rather than dynamically allocated
    
    With aligment requirements being part of the language now, it is
    simple to allocate the extra stack area in kernel data, and we
    don't need to go to so much trouble with manual allocation.
    It also makes it slightly more straightforward to use the stack
    from assembly, without having to dig through a saved context
    structure.

Change History (4)

comment:1 by Jiri Svoboda, 12 months ago

Owner: set to Jiří Zárevúcky
Status: newassigned

comment:2 by Jiri Svoboda, 4 months ago

Milestone: 0.13.10.14.1

Milestone renamed

comment:3 by Jiri Svoboda, 4 months ago

Milestone: 0.14.10.14.2

comment:4 by Jiri Svoboda, 3 days ago

Resolution: fixed
Status: assignedclosed

Fixed by MaaSTaaR in changeset af3235d07726dfc8b146c760a25544ea3ac29f9d.

Note: See TracTickets for help on using tickets.