Fork us on GitHub Follow us on Google+ Follow us on Facebook Follow us on Twitter

#676 closed defect (fixed)

ext4 shoots before it asks

Reported by: Jiri Svoboda Owned by:
Priority: minor Milestone: 0.7.1
Component: helenos/fs/ext4fs Version: mainline
Keywords: Cc:
Blocker for: Depends on:
See also:

Description

During processing a mounted request, ext4fs will do an ext4_filesystem_init(), then call ext4_filesystem_check_sanity(). If that fails, it will call ext4_filesystem_fini(). However, the init function actually writes the superblock, marking the file system as mounted, wile the fini function writes the superblock marking the file system as unmounted.

This is not very good practice. We should perform the sanity check first and only modify the on-disk image afterwards.

Change History (1)

comment:1 Changed 18 months ago by Jiri Svoboda

Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.