Fork us on GitHub Follow us on Facebook Follow us on Twitter

Opened 11 years ago

Closed 11 years ago

Last modified 10 years ago

#52 closed defect (fixed)

vfs_rename() - Bad detection of move to subdir of source dir

Reported by: Jiri Svoboda Owned by: Jakub Jermář
Priority: major Milestone: 0.4.1
Component: helenos/srv/vfs Version: mainline
Keywords: vfs rename fs Cc: jakub@…
Blocker for: Depends on:
See also:


vfs_rename() detects whether we are moving a directory to its own descendant by 1. canonifying the src and dest paths, 2. checking if src is a prefix of dest. This is wrong (t.m.) as we cannot rename 'a' to 'ab'. The prefix needs to be considered on a component level, not character level.

We should probably implement a command to test rename() first.

Change History (5)

comment:1 Changed 11 years ago by Jakub Jermář

Cc: jakub@… added
Owner: set to Jakub Jermář
Status: newaccepted

Accepting the ticket.

comment:2 Changed 11 years ago by Jakub Jermář

Keywords: fs added

comment:3 Changed 11 years ago by Jakub Jermář

Component: srv/vfs

comment:4 Changed 11 years ago by Jakub Jermář

Resolution: fixed
Status: acceptedclosed

Fixed in revision 4366.

comment:5 Changed 10 years ago by Jakub Jermář

Note: See TracTickets for help on using tickets.