TCP crashes in pq_find()

[Jakub Jermář]

This is an example of one problem currently found in the TCP server:

Running the echo server on a TCP port 8080 and connecting to it using telnet 8080 from the host system, the TCP server dies after it receives data ("ping").

See the attachments for the output of the echo server and also the stacktrace of the TCP crash.

[Jakub Jermář]

Screenshot with the stack trace.

[Jakub Jermář]

Screenshot with the echo server output.

[Jakub Jermář]

TCP server disassembled

[Jakub Jermář]

Excerpt from uspace/srv/net/structures/packet/packet.c, pq_find():

@@ -225,6 +225,8 @@
 	item = pm_find( packet->next );
 	while( item && ( item != packet )){
 		item = pm_find( item->next );
 		if( item->order == order ){
 			return item;
 		}

Looks like the second pm_find()'s return value is not checked for NULL.

[Jakub Jermář]

Fixed in changeset:head,312.