Changeset feeac0d in mainline for uspace/srv/devman/devman.c

Timestamp:

2013-09-10T16:32:35Z (12 years ago)

Author:

Jiri Svoboda <jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

4982d87

Parents:

e8d6ce2

Message:

Simplify use of list_foreach.

File:

• uspace/srv/devman/devman.c (modified) (4 diffs)

uspace/srv/devman/devman.c

@@ -496 +496 @@
 driver_t *find_best_match_driver(driver_list_t *drivers_list, dev_node_t *node)
 {
-        driver_t *best_drv = NULL, *drv = NULL;
+        driver_t *best_drv = NULL;
         int best_score = 0, score = 0;
         
         fibril_mutex_lock(&drivers_list->drivers_mutex);
         
-        list_foreach(drivers_list->drivers, link) {
-                drv = list_get_instance(link, driver_t, drivers);
+        list_foreach(drivers_list->drivers, drivers, driver_t, drv) {
                 score = get_match_score(drv, node);
                 if (score > best_score) {
@@ -596 +595 @@
 {
         driver_t *res = NULL;
-        driver_t *drv = NULL;
         
         fibril_mutex_lock(&drv_list->drivers_mutex);
         
-        list_foreach(drv_list->drivers, link) {
-                drv = list_get_instance(link, driver_t, drivers);
+        list_foreach(drv_list->drivers, drivers, driver_t, drv) {
                 if (str_cmp(drv->name, drv_name) == 0) {
                         res = drv;
@@ -1131 +1128 @@
 
         size_t pos = 0;
-        list_foreach(dev->functions, item) {
-                fun_node_t *fun =
-                    list_get_instance(item, fun_node_t, dev_functions);
-
+        list_foreach(dev->functions, dev_functions, fun_node_t, fun) {
                 if (pos < buf_cnt) {
                         hdl_buf[pos] = fun->handle;
@@ -1472 +1466 @@
         assert(fibril_rwlock_is_locked(&tree->rwlock));
 
-        fun_node_t *fun;
-
-        list_foreach(dev->functions, link) {
-                fun = list_get_instance(link, fun_node_t, dev_functions);
-
+        list_foreach(dev->functions, dev_functions, fun_node_t, fun) {
                 if (str_cmp(name, fun->name) == 0) {
                         fun_add_ref(fun);