Changeset fd07e526 in mainline for uspace/drv/bus/usb/uhci/main.c

Timestamp:

2011-09-16T14:50:20Z (13 years ago)

Author:

Jan Vesely <jano.vesely@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

432a269, d1e18573

Parents:

47fecbb (diff), 82a31261 (diff)
Note: this is a merge changeset, the changes displayed below correspond to the merge itself.
Use the (diff) links above to see all the changes relative to each parent.

Message:

Merge USB changes from bzr://krabicka.net/orome/helenos/usb/

• Move common HC code from uhci/ohci drivers to libusbhost
• Rewrite USB HC interface to have common read/write functions for all transfer types.
• Restructure hc drivers to avoid some hooks and void* casts
• Cleanup the code and remove unnecessary mallocs.

File:

• uspace/drv/bus/usb/uhci/main.c (modified) (1 diff)

uspace/drv/bus/usb/uhci/main.c

@@ -64 +64 @@
         assert(device);
 
-        int ret = device_setup_uhci(device);
+        const int ret = device_setup_uhci(device);
         if (ret != EOK) {
                 usb_log_error("Failed to initialize UHCI driver: %s.\n",
                     str_error(ret));
-                return ret;
+        } else {
+                usb_log_info("Controlling new UHCI device '%s'.\n",
+                    device->name);
         }
-        usb_log_info("Controlling new UHCI device '%s'.\n", device->name);
 
-        return EOK;
+        return ret;
 }
 /*----------------------------------------------------------------------------*/