Changeset f9d0a86 in mainline for kernel/generic/src/ipc/irq.c

Timestamp:

2017-11-14T12:24:42Z (7 years ago)

Author:

Aearsis <Hlavaty.Ondrej@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

6cad776

Parents:

887c9de (diff), d2d142a (diff)
Note: this is a merge changeset, the changes displayed below correspond to the merge itself.
Use the (diff) links above to see all the changes relative to each parent.

git-author:

Aearsis <Hlavaty.Ondrej@…> (2017-11-14 01:04:19)

git-committer:

Aearsis <Hlavaty.Ondrej@…> (2017-11-14 12:24:42)

Message:

Merge tag '0.7.1'

The merge wasn't clean, because of changes in build system. The most
significant change was partial revert of usbhc callback refactoring,
which now does not take usb transfer batch, but few named fields again.

File:

• kernel/generic/src/ipc/irq.c (modified) (2 diffs)

kernel/generic/src/ipc/irq.c

@@ -271 +271 @@
 }
 
+static void irq_hash_out(irq_t *irq)
+{
+        irq_spinlock_lock(&irq_uspace_hash_table_lock, true);
+        irq_spinlock_lock(&irq->lock, false);
+        
+        if (irq->notif_cfg.hashed_in) {
+                /* Remove the IRQ from the uspace IRQ hash table. */
+                hash_table_remove_item(&irq_uspace_hash_table, &irq->link);
+                irq->notif_cfg.hashed_in = false;
+        }
+
+        irq_spinlock_unlock(&irq->lock, false);
+        irq_spinlock_unlock(&irq_uspace_hash_table_lock, true);
+}
+
 static void irq_destroy(void *arg)
 {
         irq_t *irq = (irq_t *) arg;
+
+        irq_hash_out(irq);
 
         /* Free up the IRQ code and associated structures. */
@@ -373 +390 @@
         assert(kobj->irq->notif_cfg.answerbox == box);
 
-        irq_spinlock_lock(&irq_uspace_hash_table_lock, true);
-        irq_spinlock_lock(&kobj->irq->lock, false);
-        
-        if (kobj->irq->notif_cfg.hashed_in) {
-                /* Remove the IRQ from the uspace IRQ hash table. */
-                hash_table_remove_item(&irq_uspace_hash_table,
-                    &kobj->irq->link);
-                kobj->irq->notif_cfg.hashed_in = false;
-        }
-
-        irq_spinlock_unlock(&kobj->irq->lock, false);
-        irq_spinlock_unlock(&irq_uspace_hash_table_lock, true);
+        irq_hash_out(kobj->irq);
 
         kobject_put(kobj);