Changeset f943dd3 in mainline for uspace/drv/infrastructure/root/root.c

Timestamp:

2012-02-18T15:22:14Z (12 years ago)

Author:

Jakub Jermar <jakub@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

00aece0, a7d6185, ec8c622

Parents:

c01bb5f9

Message:

Do not leak memory in the root driver.

File:

• uspace/drv/infrastructure/root/root.c (modified) (4 diffs)

uspace/drv/infrastructure/root/root.c

@@ -158 +158 @@
         if (asprintf(&match_id, PLATFORM_FUN_MATCH_ID_FMT, platform) == -1) {
                 ddf_msg(LVL_ERROR, "Memory allocation failed.");
-                return ENOMEM;
-        }
+                free(platform);
+                return ENOMEM;
+        }
+
+        free(platform);
 
         /* Add function. */
@@ -169 +172 @@
         if (fun == NULL) {
                 ddf_msg(LVL_ERROR, "Error creating function %s", name);
+                free(match_id);
                 return ENOMEM;
         }
@@ -176 +180 @@
                 ddf_msg(LVL_ERROR, "Failed adding match IDs to function %s",
                     name);
+                free(match_id);
                 ddf_fun_destroy(fun);
                 return rc;
@@ -208 +213 @@
          * vital for the system.
          */
-        add_virtual_root_fun(dev);
+        (void) add_virtual_root_fun(dev);
 
         /* Register root device's children. */