Changeset f5837524 in mainline for uspace/srv/ns/task.c

Timestamp:

2018-10-29T17:15:02Z (5 years ago)

Author:

Jakub Jermar <jakub@…>

Children:

eec201d

Parents:

184f2f8a

git-author:

Jakub Jermar <jakub@…> (2018-10-28 12:42:35)

git-committer:

Jakub Jermar <jakub@…> (2018-10-29 17:15:02)

Message:

Use user-defined labels instead of phone hashes

This commit changes the way how the async framework maps incomming calls
to connections. Instead of abusing the kernel addresses of attached
phones as identifiers, the IPC_M_CONNECT_TO_ME and IPC_M_CONNECT_ME_TO
messages allow the server to specify an arbitrary label which is
remembered in the connected phone and consequently imprinted on each
call which is routed through this phone.

The async framework uses the address of the connection structure as the
label. This removes the need for a connection hash table because each
incoming call already remembers the connection in its label.

To disambiguate this new label and the other user-defined label used for
answers, the call structure now has the request_label member for the
former and answer_label member for the latter.

This commit also moves the kernel definition of ipc_data_t to abi/ and
removes the uspace redefinition thereof. Finally, when forwarding the
IPC_M_CONNECT_TO_ME call, the phone capability and the kernel object
allocated in request_process are now correctly disposed of.

File:

• uspace/srv/ns/task.c (modified) (8 diffs)

uspace/srv/ns/task.c

@@ -91 +91 @@
 typedef struct {
         ht_link_t link;
-        sysarg_t in_phone_hash;  /**< Incoming phone hash. */
-        task_id_t id;            /**< Task ID. */
+        sysarg_t label;  /**< Incoming phone label. */
+        task_id_t id;    /**< Task ID. */
 } p2i_entry_t;
 
-/* phone-to-id hash table operations */
+/* label-to-id hash table operations */
 
 static size_t p2i_key_hash(void *key)
 {
-        sysarg_t in_phone_hash = *(sysarg_t *)key;
-        return in_phone_hash;
+        sysarg_t label = *(sysarg_t *)key;
+        return label;
 }
 
@@ -106 +106 @@
 {
         p2i_entry_t *entry = hash_table_get_inst(item, p2i_entry_t, link);
-        return entry->in_phone_hash;
+        return entry->label;
 }
 
 static bool p2i_key_equal(void *key, const ht_link_t *item)
 {
-        sysarg_t in_phone_hash = *(sysarg_t *)key;
+        sysarg_t label = *(sysarg_t *)key;
         p2i_entry_t *entry = hash_table_get_inst(item, p2i_entry_t, link);
 
-        return (in_phone_hash == entry->in_phone_hash);
+        return (label == entry->label);
 }
 
@@ -137 +137 @@
 };
 
-/** Map phone hash to task ID */
+/** Map phone label to task ID */
 static hash_table_t phone_to_id;
 
@@ -227 +227 @@
         task_id_t id = MERGE_LOUP32(IPC_GET_ARG1(*call), IPC_GET_ARG2(*call));
 
-        ht_link_t *link = hash_table_find(&phone_to_id, &call->in_phone_hash);
+        ht_link_t *link = hash_table_find(&phone_to_id, &call->request_label);
         if (link != NULL)
                 return EEXIST;
@@ -245 +245 @@
          */
 
-        entry->in_phone_hash = call->in_phone_hash;
+        assert(call->request_label);
+        entry->label = call->request_label;
         entry->id = id;
         hash_table_insert(&phone_to_id, &entry->link);
@@ -262 +263 @@
 }
 
-static errno_t get_id_by_phone(sysarg_t phone_hash, task_id_t *id)
-{
-        ht_link_t *link = hash_table_find(&phone_to_id, &phone_hash);
+static errno_t get_id_by_phone(sysarg_t label, task_id_t *id)
+{
+        assert(label);
+        ht_link_t *link = hash_table_find(&phone_to_id, &label);
         if (link == NULL)
                 return ENOENT;
@@ -276 +278 @@
 errno_t ns_task_retval(ipc_call_t *call)
 {
-        task_id_t id = call->in_task_id;
+        task_id_t id = call->task_id;
 
         ht_link_t *link = hash_table_find(&task_hash_table, &id);
@@ -297 +299 @@
 {
         task_id_t id;
-        errno_t rc = get_id_by_phone(call->in_phone_hash, &id);
+        errno_t rc = get_id_by_phone(call->request_label, &id);
         if (rc != EOK)
                 return rc;
 
         /* Delete from phone-to-id map. */
-        hash_table_remove(&phone_to_id, &call->in_phone_hash);
+        hash_table_remove(&phone_to_id, &call->request_label);
 
         /* Mark task as finished. */