Changeset f58154c5 in mainline for uspace/drv/uhci-hcd/transfer_list.c

Timestamp:

2011-05-18T10:59:50Z (13 years ago)

Author:

Jan Vesely <jano.vesely@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

17fc40c

Parents:

b2995c3 (diff), aeca5a3 (diff)
Note: this is a merge changeset, the changes displayed below correspond to the merge itself.
Use the (diff) links above to see all the changes relative to each parent.

Message:

Minor fixes and comments

UHCI: use provided barrier defines (buffer allocator should be able to use cacheable memory)
libusb: make usb enumeration routine follow USB spec more closely (wait periods)
OHCI: handle hw errors
OHCI: use provided barrier defines (buffer allocator should be able to use cacheable memory)
OHCI: reduce maximum buffer size for one transaction, this relaxes requirements on allocator providing hw accessible buffers.(memory does not have to be continuous) The only requirement that stays is the 32bit pointers limit.

File:

• uspace/drv/uhci-hcd/transfer_list.c (modified) (4 diffs)

uspace/drv/uhci-hcd/transfer_list.c

@@ -34 +34 @@
 #include <errno.h>
 #include <usb/debug.h>
+#include <arch/barrier.h>
 
 #include "transfer_list.h"
@@ -71 +72 @@
  * @param[in] instance Memory place to use.
  *
- * Frees memory for internal qh_t structure.
+ * Frees memory of the internal qh_t structure.
  */
 void transfer_list_fini(transfer_list_t *instance)
@@ -126 +127 @@
         assert((pa & LINK_POINTER_ADDRESS_MASK) == pa);
 
+        /* Make sure all data in the batch are written */
+        write_barrier();
+
         /* keep link */
         batch_qh(batch)->next = last_qh->next;
         qh_set_next_qh(last_qh, batch_qh(batch));
 
-        asm volatile ("": : :"memory");
+        /* Make sure the pointer is updated */
+        write_barrier();
 
         /* Add to the driver list */
@@ -222 +227 @@
             == addr_to_phys(batch_qh(batch)));
         prev_qh->next = batch_qh(batch)->next;
-        asm volatile ("": : :"memory");
+
+        /* Make sure the pointer is updated */
+        write_barrier();
+
         /* Remove from the batch list */
         list_remove(&batch->link);