Changeset f3a7b0d in mainline for configure.sh

Timestamp:

2021-04-20T18:21:55Z (3 years ago)

Author:

Martin Decky <martin@…>

Branches:

master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

de227aba

Parents:

6186f9f

Message:

Use more appropriate cross-compiler installation locations

The toolchain.sh and configure.sh scripts use the
$XDG_DATA_HOME/HelenOS/cross (i.e. $HOME/.local/share/HelenOS/cross)
location by default now. This allows the cross-compiler to be
installed without super user privileges and thus hopefully lowers the
entry barrier for newcomers.

To install the cross-compiler to a system-wide location, run the
toolchain.sh script with the —system-wide option. The default
system-wide location is /opt/HelenOS/cross now.

The configure.sh script falls back to /opt/HelenOS/cross and the
previously used /usr/local/cross. Thus recompiling an already
installed cross-compiler toolchain is not necessary.

The possibility to override the cross-compiler location using
$CROSS_PREFIX or having the cross-compiler available in $PATH
retained.

File:

• configure.sh (modified) (5 diffs)

configure.sh

@@ -39 +39 @@
 CONFIG_RULES="${SOURCE_DIR}/HelenOS.config"
 CONFIG_DEFAULTS="${SOURCE_DIR}/defaults"
-
 
 test "$#" -eq 1 && { test "$1" = "-h" || test "$1" = "--help"; }
@@ -85 +84 @@
 fi
 
-if ! which meson; then
+if ! which meson >/dev/null 2>/dev/null; then
         echo "Your system does not have Meson installed."
         echo 'Please use `pip3 install meson`'
@@ -91 +90 @@
 fi
 
-if ! which ninja; then
+if ! which ninja >/dev/null 2>/dev/null; then
         echo "Your system does not have ninja installed."
         echo 'Please use `pip3 install ninja`'
@@ -98 +97 @@
 
 # Link tools directory for convenience.
-ln -s "${SOURCE_DIR}/tools" tools
+if [ ! -e tools ]; then
+        ln -s "${SOURCE_DIR}/tools" tools
+fi
 
 # Run HelenOS config tool.
@@ -122 +123 @@
 
 compname="$cc_arch-helenos-gcc"
+unset compprefix
 
-if which "$compname"; then
+if which "$compname" >/dev/null 2>/dev/null; then
         # Compiler is in PATH
         compprefix="$cc_arch-helenos-"
 
 elif [ -n "$CROSS_PREFIX" ]; then
-        if ! which "$CROSS_PREFIX/bin/$compname"; then
+        if which "$CROSS_PREFIX/bin/$compname" >/dev/null 2>/dev/null; then
+                compprefix="$CROSS_PREFIX/bin/$cc_arch-helenos-"
+        fi
+
+        if [ -z "$compprefix" ]; then
                 echo "ERROR: \$CROSS_PREFIX defined but $compname is not present in $CROSS_PREFIX/bin."
                 echo "Run tools/toolchain.sh to build cross-compiling toolchain."
                 exit 1
         fi
+else
+        if [ -z "$XDG_DATA_HOME" ]; then
+                        XDG_DATA_HOME="$HOME/.local/share"
+        fi
 
-        compprefix="$CROSS_PREFIX/bin/$cc_arch-helenos-"
-else
-        if ! which "/usr/local/cross/bin/$compname"; then
-                echo "ERROR: \$CROSS_PREFIX is not defined and $compname is not present in /usr/local/cross/bin."
+        if which "$XDG_DATA_HOME/HelenOS/cross/bin/$compname" >/dev/null 2>/dev/null; then
+                compprefix="$XDG_DATA_HOME/HelenOS/cross/bin/$cc_arch-helenos-"
+        elif which "/opt/HelenOS/cross/bin/$compname" >/dev/null 2>/dev/null; then
+                compprefix="/opt/HelenOS/cross/bin/$cc_arch-helenos-"
+        elif which "/usr/local/cross/bin/$compname" >/dev/null 2>/dev/null; then
+                compprefix="/usr/local/cross/bin/$cc_arch-helenos-"
+        fi
+
+        if [ -z "$compprefix" ]; then
+                echo "ERROR: \$CROSS_PREFIX is not defined and $compname is not present in any of the following standard locations."
+                echo " * $XDG_DATA_HOME/HelenOS/cross/bin"
+                echo " * /opt/HelenOS/cross/bin"
+                echo " * /usr/local/cross/bin"
                 echo "Run tools/toolchain.sh to build cross-compiling toolchain."
                 exit 1
         fi
-
-        compprefix="/usr/local/cross/bin/$cc_arch-helenos-"
 fi