Changeset f11c288 in mainline for uspace/drv/uhci-hcd/iface.c

Timestamp:

2011-04-09T22:20:02Z (13 years ago)

Author:

Jan Vesely <jano.vesely@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

0748854, d32ed36

Parents:

709e868 (diff), a19a2d7 (diff)
Note: this is a merge changeset, the changes displayed below correspond to the merge itself.
Use the (diff) links above to see all the changes relative to each parent.

Message:

Fix crash on endpoint_t instance removal

Remove unused default address handling (support in device_keeper_t will be removed later)
Add tons of OHCI debug output (still not working), and some fixes found by using that debug output.

File:

• uspace/drv/uhci-hcd/iface.c (modified) (5 diffs)

uspace/drv/uhci-hcd/iface.c

@@ -74 +74 @@
             name, target.address, target.endpoint, size, ep->max_packet_size);
 
-//      assert(ep->speed ==
-//          usb_device_keeper_get_speed(&(*hc)->manager, target.address));
-//      assert(ep->max_packet_size == max_packet_size);
-//      assert(ep->transfer_type == USB_TRANSFER_CONTROL);
-
-        *batch =
-            batch_get(fun, ep, data, size, setup_data, setup_size,
-                in, out, arg);
-        if (!batch)
+        *batch = batch_get(
+                fun, ep, data, size, setup_data, setup_size, in, out, arg);
+        if (!*batch)
                 return ENOMEM;
-        return EOK;
-}
-
-
-/** Reserve default address interface function
- *
- * @param[in] fun DDF function that was called.
- * @param[in] speed Speed to associate with the new default address.
- * @return Error code.
- */
-static int reserve_default_address(ddf_fun_t *fun, usb_speed_t speed)
-{
-        assert(fun);
-        hc_t *hc = fun_to_hc(fun);
-        assert(hc);
-        usb_log_debug("Default address request with speed %d.\n", speed);
-        usb_device_keeper_reserve_default_address(&hc->manager, speed);
-        return EOK;
-#if 0
-        endpoint_t *ep = malloc(sizeof(endpoint_t));
-        if (ep == NULL)
-                return ENOMEM;
-        const size_t max_packet_size = speed == USB_SPEED_LOW ? 8 : 64;
-        endpoint_init(ep, USB_TRANSFER_CONTROL, speed, max_packet_size);
-        int ret;
-try_retgister:
-        ret = usb_endpoint_manager_register_ep(&hc->ep_manager,
-            USB_ADDRESS_DEFAULT, 0, USB_DIRECTION_BOTH, ep, endpoint_destroy, 0);
-        if (ret == EEXISTS) {
-                async_usleep(1000);
-                goto try_retgister;
-        }
-        if (ret != EOK) {
-                endpoint_destroy(ep);
-        }
-        return ret;
-#endif
-}
-/*----------------------------------------------------------------------------*/
-/** Release default address interface function
- *
- * @param[in] fun DDF function that was called.
- * @return Error code.
- */
-static int release_default_address(ddf_fun_t *fun)
-{
-        assert(fun);
-        hc_t *hc = fun_to_hc(fun);
-        assert(hc);
-        usb_log_debug("Default address release.\n");
-//      return usb_endpoint_manager_unregister_ep(&hc->ep_manager,
-//          USB_ADDRESS_DEFAULT, 0, USB_DIRECTION_BOTH);
-        usb_device_keeper_release_default_address(&hc->manager);
         return EOK;
 }
@@ -232 +173 @@
         if (ret != EOK) {
                 endpoint_destroy(ep);
-        } else {
-                usb_device_keeper_add_ep(&hc->manager, address, ep);
         }
         return ret;
@@ -246 +185 @@
         usb_log_debug("Unregister endpoint %d:%d %d.\n",
             address, endpoint, direction);
-        endpoint_t *ep = usb_endpoint_manager_get_ep(&hc->ep_manager,
-            address, endpoint, direction, NULL);
-        if (ep != NULL) {
-                usb_device_keeper_del_ep(&hc->manager, address, ep);
-        }
         return usb_endpoint_manager_unregister_ep(&hc->ep_manager, address,
             endpoint, direction);
@@ -391 +325 @@
         if (ret != EOK)
                 return ret;
-        usb_device_keeper_reset_if_need(&hc->manager, target, setup_data);
+        usb_endpoint_manager_reset_if_need(&hc->ep_manager, target, setup_data);
         batch_control_write(batch);
         ret = hc_schedule(hc, batch);
@@ -433 +367 @@
 /*----------------------------------------------------------------------------*/
 usbhc_iface_t hc_iface = {
-        .reserve_default_address = reserve_default_address,
-        .release_default_address = release_default_address,
         .request_address = request_address,
         .bind_address = bind_address,