Changeset f023251 in mainline for uspace/srv/net/inetsrv/icmp.c

Timestamp:

2013-09-29T21:06:10Z (11 years ago)

Author:

Jiri Svoboda <jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

e948fde

Parents:

13be2583

Message:

HelenOS internet address version should not be based on BSD sockets definition.

File:

• uspace/srv/net/inetsrv/icmp.c (modified) (3 diffs)

uspace/srv/net/inetsrv/icmp.c

@@ -123 +123 @@
 {
         log_msg(LOG_DEFAULT, LVL_DEBUG, "icmp_recv_echo_reply()");
-        
+
         if (dgram->size < sizeof(icmp_echo_t))
                 return EINVAL;
-        
+
         icmp_echo_t *reply = (icmp_echo_t *) dgram->data;
-        
+
         inetping_sdu_t sdu;
-        
-        uint16_t family = inet_addr_get(&dgram->src, &sdu.src, NULL);
-        if (family != AF_INET)
+
+        ip_ver_t ver = inet_addr_get(&dgram->src, &sdu.src, NULL);
+        if (ver != ip_v4)
                 return EINVAL;
-        
-        family = inet_addr_get(&dgram->dest, &sdu.dest, NULL);
-        if (family != AF_INET)
+
+        ver = inet_addr_get(&dgram->dest, &sdu.dest, NULL);
+        if (ver != ip_v4)
                 return EINVAL;
-        
+
         sdu.seq_no = uint16_t_be2host(reply->seq_no);
         sdu.data = reply + sizeof(icmp_echo_t);
         sdu.size = dgram->size - sizeof(icmp_echo_t);
-        
+
         uint16_t ident = uint16_t_be2host(reply->ident);
 
@@ -154 +154 @@
         if (rdata == NULL)
                 return ENOMEM;
-        
+
         icmp_echo_t *request = (icmp_echo_t *) rdata;
-        
+
         request->type = ICMP_ECHO_REQUEST;
         request->code = 0;
@@ -162 +162 @@
         request->ident = host2uint16_t_be(ident);
         request->seq_no = host2uint16_t_be(sdu->seq_no);
-        
+
         memcpy(rdata + sizeof(icmp_echo_t), sdu->data, sdu->size);
-        
+
         uint16_t checksum = inet_checksum_calc(INET_CHECKSUM_INIT, rdata, rsize);
         request->checksum = host2uint16_t_be(checksum);
-        
+
         inet_dgram_t dgram;
-        
+
         inet_addr_set(sdu->src, &dgram.src);
         inet_addr_set(sdu->dest, &dgram.dest);
-        
+
         dgram.iplink = 0;
         dgram.tos = ICMP_TOS;
         dgram.data = rdata;
         dgram.size = rsize;
-        
+
         int rc = inet_route_packet(&dgram, IP_PROTO_ICMP, INET_TTL_MAX, 0);
-        
+
         free(rdata);
         return rc;