Changes in / [5174c62:ec6ab88] in mainline

Location:

uspace

Files:

• app/virtusbkbd/Makefile (modified) (1 diff)
• drv/usbkbd/main.c (modified) (2 diffs)
• lib/usb/include/usb/classes/hid.h (modified) (2 diffs)
• lib/usb/include/usb/classes/hidparser.h (modified) (1 diff)
• lib/usb/src/hidparser.c (modified) (1 diff)

uspace/app/virtusbkbd/Makefile

@@ -33 +33 @@
 
 LIBS = $(LIBUSB_PREFIX)/libusb.a $(LIBUSBVIRT_PREFIX)/libusbvirt.a
-EXTRA_CFLAGS = -I$(LIBUSB_PREFIX)/include -I$(LIB_PREFIX)
+EXTRA_CFLAGS = -I$(LIBUSB_PREFIX)/include -I$(LIB_PREFIX) -I$(LIBDRV_PREFIX)/include
 
 SOURCES = \

uspace/drv/usbkbd/main.c

@@ -28 +28 @@
 #include <usb/usbdrv.h>
 #include <driver.h>
+#include <ipc/driver.h>
 #include <errno.h>
+#include <fibril.h>
+#include <usb/classes/hid.h>
+#include <usb/classes/hidparser.h>
+#include <usb/devreq.h>
 
 #define BUFFER_SIZE 32
-
-/* Call this periodically to check keyboard status changes. */
-static void poll_keyboard(device_t *dev)
+#define NAME "usbkbd"
+
+static const usb_endpoint_t CONTROL_EP = 0;
+
+/*
+ * Callbacks for parser
+ */
+static void usbkbd_process_keycodes(const uint16_t *key_codes, size_t count,
+                                    void *arg)
+{
+
+}
+
+/*
+ * Kbd functions
+ */
+static int usbkbd_get_descriptors()
+{
+        // copy-pasted:
+        
+        /* Prepare the setup packet. */
+        usb_device_request_setup_packet_t setup_packet = {
+                .request_type = 128,
+                .request = USB_DEVREQ_GET_DESCRIPTOR,
+                .index = 0,
+                .length = sizeof(usb_standard_device_descriptor_t)
+        };
+        
+        setup_packet.value_high = USB_DESCTYPE_DEVICE;
+        setup_packet.value_low = 0;
+
+        /* Prepare local descriptor. */
+        size_t actually_transferred = 0;
+        usb_standard_device_descriptor_t descriptor_tmp;
+
+        /* Perform the control read transaction. */
+        int rc = usb_drv_psync_control_read(phone, target,
+            &setup_packet, sizeof(setup_packet),
+            &descriptor_tmp, sizeof(descriptor_tmp), &actually_transferred);
+
+        if (rc != EOK) {
+                return rc;
+        }
+        
+        // end of copy-paste
+}
+
+static usb_hid_dev_kbd_t *usbkbd_init_device(device_t *dev)
+{
+        usb_hid_dev_kbd_t *kbd_dev = (usb_hid_dev_kbd_t *)malloc(
+                        sizeof(usb_hid_dev_kbd_t));
+
+        if (kbd_dev == NULL) {
+                fprintf(stderr, NAME ": No memory!\n");
+                return NULL;
+        }
+
+        kbd_dev->device = dev;
+
+        // get phone to my HC and save it as my parent's phone
+        // TODO: maybe not a good idea if DDF will use parent_phone
+        kbd_dev->device->parent_phone = usb_drv_hc_connect(dev, 0);
+
+        kbd_dev->address = usb_drv_get_my_address(dev->parent_phone,
+            dev);
+
+        // doesn't matter now that we have no address
+//      if (kbd_dev->address < 0) {
+//              fprintf(stderr, NAME ": No device address!\n");
+//              free(kbd_dev);
+//              return NULL;
+//      }
+
+        // default endpoint
+        kbd_dev->default_ep = CONTROL_EP;
+
+        // TODO: get descriptors
+        usbkbd_get_descriptors();
+        // TODO: parse descriptors and save endpoints
+
+        return kbd_dev;
+}
+
+static void usbkbd_process_interrupt_in(usb_hid_dev_kbd_t *kbd_dev,
+                                        uint8_t *buffer, size_t actual_size)
+{
+        /*
+         * here, the parser will be called, probably with some callbacks
+         * now only take last 6 bytes and process, i.e. send to kbd
+         */
+
+        usb_hid_report_in_callbacks_t *callbacks =
+            (usb_hid_report_in_callbacks_t *)malloc(
+                sizeof(usb_hid_report_in_callbacks_t));
+        callbacks->keyboard = usbkbd_process_keycodes;
+
+        usb_hid_parse_report(kbd_dev->parser, buffer, callbacks, NULL);
+}
+
+static void usbkbd_poll_keyboard(usb_hid_dev_kbd_t *kbd_dev)
 {
         int rc;
         usb_handle_t handle;
-        char buffer[BUFFER_SIZE];
+        uint8_t buffer[BUFFER_SIZE];
         size_t actual_size;
-        usb_endpoint_t poll_endpoint = 1;
-
-        usb_address_t my_address = usb_drv_get_my_address(dev->parent_phone,
-            dev);
-        if (my_address < 0) {
-                return;
-        }
+        //usb_endpoint_t poll_endpoint = 1;
+
+//      usb_address_t my_address = usb_drv_get_my_address(dev->parent_phone,
+//          dev);
+//      if (my_address < 0) {
+//              return;
+//      }
 
         usb_target_t poll_target = {
-                .address = my_address,
-                .endpoint = poll_endpoint
+                .address = kbd_dev->address,
+                .endpoint = kbd_dev->default_ep
         };
 
-        rc = usb_drv_async_interrupt_in(dev->parent_phone, poll_target,
-            buffer, BUFFER_SIZE, &actual_size, &handle);
-        if (rc != EOK) {
-                return;
-        }
-
-        rc = usb_drv_async_wait_for(handle);
-        if (rc != EOK) {
-                return;
-        }
-
-        /*
-         * If the keyboard answered with NAK, it returned no data.
-         * This implies that no change happened since last query.
-         */
-        if (actual_size == 0) {
-                return;
-        }
-
-        /*
-         * Process pressed keys.
-         */
-}
-
-static int add_kbd_device(device_t *dev)
+        while (true) {
+                rc = usb_drv_async_interrupt_in(kbd_dev->device->parent_phone,
+                    poll_target, buffer, BUFFER_SIZE, &actual_size, &handle);
+
+                if (rc != EOK) {
+                        continue;
+                }
+
+                rc = usb_drv_async_wait_for(handle);
+                if (rc != EOK) {
+                        continue;
+                }
+
+                /*
+                 * If the keyboard answered with NAK, it returned no data.
+                 * This implies that no change happened since last query.
+                 */
+                if (actual_size == 0) {
+                        continue;
+                }
+
+                /*
+                 * TODO: Process pressed keys.
+                 */
+                usbkbd_process_interrupt_in(kbd_dev, buffer, actual_size);
+        }
+
+        // not reached
+        assert(0);
+}
+
+static int usbkbd_fibril_device(void *arg)
+{
+        printf("!!! USB device fibril\n");
+
+        if (arg == NULL) {
+                printf("No device!\n");
+                return -1;
+        }
+
+        device_t *dev = (device_t *)arg;
+
+        // initialize device (get and process descriptors, get address, etc.)
+        usb_hid_dev_kbd_t *kbd_dev = usbkbd_init_device(dev);
+
+        usbkbd_poll_keyboard(kbd_dev);
+
+        return EOK;
+}
+
+static int usbkbd_add_device(device_t *dev)
 {
         /* For now, fail immediately. */
-        return ENOTSUP;
+        //return ENOTSUP;
 
         /*
          * When everything is okay, connect to "our" HC.
-         */
-        int phone = usb_drv_hc_connect(dev, 0);
-        if (phone < 0) {
-                /*
-                 * Connecting to HC failed, roll-back and announce
-                 * failure.
-                 */
-                return phone;
-        }
-
-        dev->parent_phone = phone;
-
-        /*
-         * Just for fun ;-).
-         */
-        poll_keyboard(dev);
+         *
+         * Not supported yet, skip..
+         */
+//      int phone = usb_drv_hc_connect(dev, 0);
+//      if (phone < 0) {
+//              /*
+//               * Connecting to HC failed, roll-back and announce
+//               * failure.
+//               */
+//              return phone;
+//      }
+
+//      dev->parent_phone = phone;
+
+        /*
+         * Create new fibril for handling this keyboard
+         */
+        fid_t fid = fibril_create(usbkbd_fibril_device, dev);
+        if (fid == 0) {
+                printf("%s: failed to start fibril for HID device\n", NAME);
+                return ENOMEM;
+        }
+        fibril_add_ready(fid);
 
         /*
@@ -107 +242 @@
 
 static driver_ops_t kbd_driver_ops = {
-        .add_device = add_kbd_device,
+        .add_device = usbkbd_add_device,
 };
 
 static driver_t kbd_driver = {
-        .name = "usbkbd",
+        .name = NAME,
         .driver_ops = &kbd_driver_ops
 };

uspace/lib/usb/include/usb/classes/hid.h

@@ -36 +36 @@
 #define LIBUSB_HID_H_
 
+#include <usb/usb.h>
+#include <driver.h>
+#include <usb/classes/hidparser.h>
+
 /** USB/HID device requests. */
 typedef enum {
@@ -54 +58 @@
 } usb_hid_protocol_t;
 
+/**
+ * @brief USB/HID keyboard device type.
+ *
+ * Quite dummy right now.
+ */
+typedef struct {
+        device_t *device;
+        usb_address_t address;
+        usb_endpoint_t default_ep;
+        usb_hid_report_parser_t *parser;
+} usb_hid_dev_kbd_t;
+
 #endif
 /**

uspace/lib/usb/include/usb/classes/hidparser.h

@@ -50 +50 @@
          * @param arg Custom argument.
          */
-        void (*keyboard)(const uint32_t *key_codes, size_t count, void *arg);
+        void (*keyboard)(const uint16_t *key_codes, size_t count, void *arg);
 } usb_hid_report_in_callbacks_t;
 

uspace/lib/usb/src/hidparser.c

@@ -62 +62 @@
     const usb_hid_report_in_callbacks_t *callbacks, void *arg)
 {
-        return ENOTSUP;
+        int i;
+        
+        // TODO: parse report
+        
+        uint16_t keys[6];
+        
+        for (i = 0; i < 6; ++i) {
+                keys[i] = data[i];
+        }
+        
+        callbacks->keyboard(keys, 6, arg);
 }