Changeset ebcb05a in mainline for uspace/drv/pciintel/pci.c

Timestamp:

2011-04-01T19:00:51Z (13 years ago)

Author:

Jiri Svoboda <jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

969585f, ea53529

Parents:

bdbb6f6

Message:

Logging functions should append newline automatically. Since one has no
choice but to end log message with a newline, there is no need to do it
manually in every invocation.

File:

• uspace/drv/pciintel/pci.c (modified) (15 diffs)

uspace/drv/pciintel/pci.c

@@ -226 +226 @@
 
         if (match_id_str == NULL) {
-                ddf_msg(LVL_ERROR, "Out of memory creating match ID.\n");
+                ddf_msg(LVL_ERROR, "Out of memory creating match ID.");
                 return;
         }
@@ -232 +232 @@
         rc = ddf_fun_add_match_id(fun->fnode, match_id_str, 90);
         if (rc != EOK) {
-                ddf_msg(LVL_ERROR, "Failed adding match ID: %s\n",
+                ddf_msg(LVL_ERROR, "Failed adding match ID: %s",
                     str_error(rc));
         }
@@ -325 +325 @@
         if (range_addr != 0) {
                 ddf_msg(LVL_DEBUG, "Function %s : address = %" PRIx64
-                    ", size = %x\n", fun->fnode->name, range_addr,
+                    ", size = %x", fun->fnode->name, range_addr,
                     (unsigned int) range_size);
         }
@@ -351 +351 @@
         hw_res_list->count++;
         
-        ddf_msg(LVL_NOTE, "Function %s uses irq %x.\n", fun->fnode->name, irq);
+        ddf_msg(LVL_NOTE, "Function %s uses irq %x.", fun->fnode->name, irq);
 }
 
@@ -407 +407 @@
                         char *fun_name = pci_fun_create_name(fun);
                         if (fun_name == NULL) {
-                                ddf_msg(LVL_ERROR, "Out of memory.\n");
+                                ddf_msg(LVL_ERROR, "Out of memory.");
                                 return;
                         }
@@ -413 +413 @@
                         fnode = ddf_fun_create(bus->dnode, fun_inner, fun_name);
                         if (fnode == NULL) {
-                                ddf_msg(LVL_ERROR, "Failed creating function.\n");
+                                ddf_msg(LVL_ERROR, "Failed creating function.");
                                 return;
                         }
@@ -427 +427 @@
                         fnode->driver_data = fun;
                         
-                        ddf_msg(LVL_DEBUG, "Adding new function %s.\n",
+                        ddf_msg(LVL_DEBUG, "Adding new function %s.",
                             fnode->name);
                         
@@ -445 +445 @@
                                     PCI_BRIDGE_SEC_BUS_NUM);
                                 ddf_msg(LVL_DEBUG, "Device is pci-to-pci "
-                                    "bridge, secondary bus number = %d.\n",
+                                    "bridge, secondary bus number = %d.",
                                     bus_num);
                                 if (child_bus > bus_num)
@@ -468 +468 @@
         int rc;
         
-        ddf_msg(LVL_DEBUG, "pci_add_device\n");
+        ddf_msg(LVL_DEBUG, "pci_add_device");
         dnode->parent_phone = -1;
         
         bus = pci_bus_new();
         if (bus == NULL) {
-                ddf_msg(LVL_ERROR, "pci_add_device allocation failed.\n");
+                ddf_msg(LVL_ERROR, "pci_add_device allocation failed.");
                 rc = ENOMEM;
                 goto fail;
@@ -484 +484 @@
         if (dnode->parent_phone < 0) {
                 ddf_msg(LVL_ERROR, "pci_add_device failed to connect to the "
-                    "parent's driver.\n");
+                    "parent's driver.");
                 rc = dnode->parent_phone;
                 goto fail;
@@ -494 +494 @@
         if (rc != EOK) {
                 ddf_msg(LVL_ERROR, "pci_add_device failed to get hw resources "
-                    "for the device.\n");
+                    "for the device.");
                 goto fail;
         }
         got_res = true;
         
-        ddf_msg(LVL_DEBUG, "conf_addr = %" PRIx64 ".\n",
+        ddf_msg(LVL_DEBUG, "conf_addr = %" PRIx64 ".",
             hw_resources.resources[0].res.io_range.address);
         
@@ -511 +511 @@
         if (pio_enable((void *)(uintptr_t)bus->conf_io_addr, 8,
             &bus->conf_addr_port)) {
-                ddf_msg(LVL_ERROR, "Failed to enable configuration ports.\n");
+                ddf_msg(LVL_ERROR, "Failed to enable configuration ports.");
                 rc = EADDRNOTAVAIL;
                 goto fail;
@@ -518 +518 @@
         
         /* Make the bus device more visible. It has no use yet. */
-        ddf_msg(LVL_DEBUG, "Adding a 'ctl' function\n");
+        ddf_msg(LVL_DEBUG, "Adding a 'ctl' function");
         
         ctl = ddf_fun_create(bus->dnode, fun_exposed, "ctl");
         if (ctl == NULL) {
-                printf(NAME ": error creating control function.\n");
+                ddf_msg(LVL_ERROR, "Failed creating control function.");
                 rc = ENOMEM;
                 goto fail;
@@ -529 +529 @@
         rc = ddf_fun_bind(ctl);
         if (rc != EOK) {
-                printf(NAME ": error binding control function.\n");
+                ddf_msg(LVL_ERROR, "Failed binding control function.");
                 goto fail;
         }
         
         /* Enumerate functions. */
-        ddf_msg(LVL_DEBUG, "Scanning the bus\n");
+        ddf_msg(LVL_DEBUG, "Scanning the bus");
         pci_bus_scan(bus, 0);
         
@@ -634 +634 @@
 int main(int argc, char *argv[])
 {
-        printf(NAME ": HelenOS pci bus driver (intel method 1).\n");
+        printf(NAME ": HelenOS PCI bus driver (Intel method 1).\n");
         pciintel_init();
         return ddf_driver_main(&pci_driver);