Changeset ebcb05a in mainline for uspace/drv/isa/isa.c

Timestamp:

2011-04-01T19:00:51Z (13 years ago)

Author:

Jiri Svoboda <jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

969585f, ea53529

Parents:

bdbb6f6

Message:

Logging functions should append newline automatically. Since one has no
choice but to end log message with a newline, there is no need to do it
manually in every invocation.

File:

• uspace/drv/isa/isa.c (modified) (12 diffs)

uspace/drv/isa/isa.c

@@ -135 +135 @@
         fd = open(conf_path, O_RDONLY);
         if (fd < 0) {
-                ddf_msg(LVL_ERROR, "Unable to open %s\n", conf_path);
+                ddf_msg(LVL_ERROR, "Unable to open %s", conf_path);
                 goto cleanup;
         }
@@ -144 +144 @@
         lseek(fd, 0, SEEK_SET);
         if (len == 0) {
-                ddf_msg(LVL_ERROR, "Configuration file '%s' is empty.\n",
+                ddf_msg(LVL_ERROR, "Configuration file '%s' is empty.",
                     conf_path);
                 goto cleanup;
@@ -151 +151 @@
         buf = malloc(len + 1);
         if (buf == NULL) {
-                ddf_msg(LVL_ERROR, "Memory allocation failed.\n");
+                ddf_msg(LVL_ERROR, "Memory allocation failed.");
                 goto cleanup;
         }
 
         if (0 >= read(fd, buf, len)) {
-                ddf_msg(LVL_ERROR, "Unable to read file '%s'.\n", conf_path);
+                ddf_msg(LVL_ERROR, "Unable to read file '%s'.", conf_path);
                 goto cleanup;
         }
@@ -252 +252 @@
                 fun->hw_resources.count++;
 
-                ddf_msg(LVL_NOTE, "Added irq 0x%x to function %s\n", irq,
+                ddf_msg(LVL_NOTE, "Added irq 0x%x to function %s", irq,
                     fun->fnode->name);
         }
@@ -271 +271 @@
 
                 ddf_msg(LVL_NOTE, "Added io range (addr=0x%x, size=0x%x) to "
-                    "function %s\n", (unsigned int) addr, (unsigned int) len,
+                    "function %s", (unsigned int) addr, (unsigned int) len,
                     fun->fnode->name);
         }
@@ -332 +332 @@
         if (val == end) {
                 ddf_msg(LVL_ERROR, "Cannot read match score for function "
-                    "%s.\n", fun->fnode->name);
+                    "%s.", fun->fnode->name);
                 return;
         }
@@ -339 +339 @@
         get_match_id(&id, val);
         if (id == NULL) {
-                ddf_msg(LVL_ERROR, "Cannot read match ID for function %s.\n",
+                ddf_msg(LVL_ERROR, "Cannot read match ID for function %s.",
                     fun->fnode->name);
                 return;
@@ -345 +345 @@
 
         ddf_msg(LVL_DEBUG, "Adding match id '%s' with score %d to "
-            "function %s\n", id, score, fun->fnode->name);
+            "function %s", id, score, fun->fnode->name);
 
         rc = ddf_fun_add_match_id(fun->fnode, id, score);
         if (rc != EOK) {
-                ddf_msg(LVL_ERROR, "Failed adding match ID: %s\n",
+                ddf_msg(LVL_ERROR, "Failed adding match ID: %s",
                     str_error(rc));
         }
@@ -379 +379 @@
             !prop_parse(fun, line, "match", &fun_parse_match_id)) {
 
-                ddf_msg(LVL_ERROR, "Undefined device property at line '%s'\n",
+                ddf_msg(LVL_ERROR, "Undefined device property at line '%s'",
                     line);
         }
@@ -441 +441 @@
         fun->fnode->ops = &isa_fun_ops;
 
-        ddf_msg(LVL_DEBUG, "Binding function %s.\n", fun->fnode->name);
+        ddf_msg(LVL_DEBUG, "Binding function %s.", fun->fnode->name);
 
         /* XXX Handle error */
@@ -469 +469 @@
 static int isa_add_device(ddf_dev_t *dev)
 {
-        ddf_msg(LVL_DEBUG, "isa_add_device, device handle = %d\n",
+        ddf_msg(LVL_DEBUG, "isa_add_device, device handle = %d",
             (int) dev->handle);
 
         /* Make the bus device more visible. Does not do anything. */
-        ddf_msg(LVL_DEBUG, "Adding a 'ctl' function\n");
+        ddf_msg(LVL_DEBUG, "Adding a 'ctl' function");
 
         ddf_fun_t *ctl = ddf_fun_create(dev, fun_exposed, "ctl");
         if (ctl == NULL) {
-                ddf_msg(LVL_ERROR, "Failed creating control function.\n");
+                ddf_msg(LVL_ERROR, "Failed creating control function.");
                 return EXDEV;
         }
 
         if (ddf_fun_bind(ctl) != EOK) {
-                ddf_msg(LVL_ERROR, "Failed binding control function.\n");
+                ddf_msg(LVL_ERROR, "Failed binding control function.");
                 return EXDEV;
         }
@@ -488 +488 @@
         /* Add functions as specified in the configuration file. */
         isa_functions_add(dev);
-        ddf_msg(LVL_NOTE, "Finished enumerating legacy functions\n");
+        ddf_msg(LVL_NOTE, "Finished enumerating legacy functions");
 
         return EOK;