Changeset eb928c4 in mainline for uspace/drv/bus/usb/xhci/transfers.c

Timestamp:

2018-01-08T00:07:00Z (6 years ago)

Author:

Ondřej Hlavatý <aearsis@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

1102eca

Parents:

ecbad17

git-author:

Ondřej Hlavatý <aearsis@…> (2018-01-08 00:05:39)

git-committer:

Ondřej Hlavatý <aearsis@…> (2018-01-08 00:07:00)

Message:

xhci: documentation & cleanup

Also, a simple refactoring to remove functions that only wraps another
functions unused anywhere else.

File:

• uspace/drv/bus/usb/xhci/transfers.c (modified) (2 diffs)

uspace/drv/bus/usb/xhci/transfers.c

@@ -94 +94 @@
 
 /**
- * There can currently be only one active transfer, because
- * usb_transfer_batch_init locks the endpoint by endpoint_use.
- * Therefore, we store the only active transfer per endpoint there.
- */
-xhci_transfer_t* xhci_transfer_create(endpoint_t* ep)
+ * Create a xHCI-specific transfer batch.
+ *
+ * Bus callback.
+ */
+usb_transfer_batch_t * xhci_transfer_create(endpoint_t* ep)
 {
         xhci_transfer_t *transfer = calloc(1, sizeof(xhci_transfer_t));
@@ -105 +105 @@
 
         usb_transfer_batch_init(&transfer->batch, ep);
-        return transfer;
-}
-
-void xhci_transfer_destroy(xhci_transfer_t* transfer)
-{
-        assert(transfer);
+        return &transfer->batch;
+}
+
+/**
+ * Destroy a xHCI transfer.
+ */
+void xhci_transfer_destroy(usb_transfer_batch_t* batch)
+{
+        xhci_transfer_t *transfer = xhci_transfer_from_batch(batch);
 
         dma_buffer_free(&transfer->hc_buffer);